[SQL] Add managed hsm regex match to SQL#15109
Conversation
|
SQL |
|
@bim-msft could you help take a look at hsm part? |
|
Hi @kingsleyAzure, could you fix CI failure first? |
Juliehzl
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @kingsleyAzure, could you take a look on style error and make CI pass? |
|
Hi @Juliehzl Can you please retry the pipeline? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
please rerun the pipeline. I fixed the line too long error. |
|
Hi @kingsleyAzure, CI is triggered automatically with your commit. But there are more failures occurred. You could see more in |
|
|
||
| match = re.match(r'^https(.)+\.vault(.)+\/keys\/[^\/]+\/[0-9a-zA-Z]+$', uri) | ||
|
|
||
| match = re.match(r'https://(.)+\.(managedhsm.azure.net|managedhsm-preview.azure.net|vault.azure.net|vault-int.azure-int.net|vault.azure.cn|managedhsm.azure.cn|vault.usgovcloudapi.net|managedhsm.usgovcloudapi.net|vault.microsoftazure.de|managedhsm.microsoftazure.de|vault.cloudapi.eaglex.ic.gov|vault.cloudapi.microsoft.scloud)(:443)?\/keys/[^\/]+\/[0-9a-zA-Z]+$', uri) |
There was a problem hiding this comment.
please add comment to clarify what you do for regex.
|
|
||
| match = re.match(r'^https(.)+\.vault(.)+\/keys\/[^\/]+\/[0-9a-zA-Z]+$', uri) | ||
|
|
||
| match = re.match(r'https://(.)+\.(managedhsm.azure.net|managedhsm-preview.azure.net|vault.azure.net|vault-int.azure-int.net|vault.azure.cn|managedhsm.azure.cn|vault.usgovcloudapi.net|managedhsm.usgovcloudapi.net|vault.microsoftazure.de|managedhsm.microsoftazure.de|vault.cloudapi.eaglex.ic.gov|vault.cloudapi.microsoft.scloud)(:443)?\/keys/[^\/]+\/[0-9a-zA-Z]+$', uri) |
There was a problem hiding this comment.
Do you support Azure Stack cloud? It seems with your current regex, only some known could are supported. If there are new cloud supported, you will need to change the regex here, right?
There was a problem hiding this comment.
currently we do not support Azure stack.
Juliehzl
requested review from
fengzhou-msft and
houk-ms
and removed request for
mmyyrroonn
|
@fengzhou-msft @houk-ms Could you help check the regex for hsm and keyvault? |
|
@kingsleyAzure May I ask where did you get the list of the KeyVault endpoints? I suggest we do some general regex here to fuzzily match |
|
This was retrieved from a list of supported endpoint which we tested and validated. There might be some other endpoints which gets matched by fuzz logic, but was not tested and validated. that might create trouble. So that is why I put those validated endpoints into regex because I do not want a match or any other type of endpoints besides the one I listed in regex, even they might exist in current azure offerings. |
|
The same regex match is done in powershell as well. |
6 participants
Description
Extend Current Regex matching to include managed hsm URIs since Managed HSM is supported in SQL now.