-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ARM] az tag support for resource id parameter #14558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ARM |
|
@Grayer123 May I ask can PR #13429 be closed? |
zhoxing-ms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jsntcy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
Could it be merged and add to S173 release please? @zhoxing-ms, @Juliehzl |
Co-authored-by: Zunli Hu <[email protected]>
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
Juliehzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved if CI passes
Description
This is a replacement for the existing pr: az tag support for -id parameter, as there are too many conflicts while merging the dev branch. Creating this pr to only include tags related changes.
We are working on expanding our tags related cli cmdlets, to be more specific, adding the following cmdlets:
At this stage, we are just supporting –-resourceid for all cmdlets, and they will look like as following:(supporting both --resourceid and -id)
We have the same design in the PowerShell cmdlet, please see this powershell design pr for more details.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.