Skip to content

Conversation

@Grayer123
Copy link
Contributor

@Grayer123 Grayer123 commented Jul 29, 2020

Description

This is a replacement for the existing pr: az tag support for -id parameter, as there are too many conflicts while merging the dev branch. Creating this pr to only include tags related changes.
We are working on expanding our tags related cli cmdlets, to be more specific, adding the following cmdlets:

  • Gets the entire set of tags on a resource, resource group or subscription. (later more proxy resources will be supported)
  • Creates or updates the entire set of tags on a resource, resource group or subscription.
  • Selectively updates the set of tags on a resource, resource group or subscription.
  • Deletes the entire set of tags on a resource, resource group or subscription.

At this stage, we are just supporting –-resourceid for all cmdlets, and they will look like as following:(supporting both --resourceid and -id)

  • az tag list –-resourceid {resourceId}
  • az tag create –-resourceid {resourceId} –-tags {tags_list}
  • az tag update –-resourceid {resourceId} –-operation {patch_operation} –-tags {tags_list} (the operations include merge, replace and delete)
  • az tag delete –-resourceid {resourceId}
    We have the same design in the PowerShell cmdlet, please see this powershell design pr for more details.

Testing Guide

  • Add test cases for subscription, resource group, and tracked resources for all added tags cmdlets.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan requested review from jsntcy and mmyyrroonn July 29, 2020 02:52
@yonzhan yonzhan added this to the S174 milestone Jul 29, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2020

ARM

@zhoxing-ms
Copy link
Contributor

@Grayer123 May I ask can PR #13429 be closed?

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsntcy jsntcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Grayer123
Copy link
Contributor Author

Could it be merged and add to S173 release please? @zhoxing-ms, @Juliehzl

Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved if CI passes

@zhoxing-ms zhoxing-ms merged commit 3da8865 into Azure:dev Jul 31, 2020
@Grayer123 Grayer123 deleted the feature/tagcli branch September 12, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants