Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Jul 6, 2020

Description
Fix #11949: geographyGroup is missing from az account list-locations

This PR bumps azure.mgmt.resource.subscriptions to 2019-11-01 which was released in Azure/azure-sdk-for-python#11482.

Testing Guide

> az account list-locations
[
  {
    "displayName": "East US",
    "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/locations/eastus",
    "metadata": {
      "geographyGroup": "US",          <<<<<<<<<<<<<<<<<<
      "latitude": "37.3719",
      "longitude": "-79.8164",
      "pairedRegion": [
        {
          "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/locations/westus",
          "name": "westus",
          "subscriptionId": null
        }
      ],
      "physicalLocation": "Virginia",
      "regionCategory": "Recommended",
      "regionType": "Physical"
    },
    "name": "eastus",
    "regionalDisplayName": "(US) East US",
    "subscriptionId": null
  },
  ...

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 6, 2020

Bump subscription

@jiasli jiasli requested a review from qwordy as a code owner July 6, 2020 09:18
@jiasli
Copy link
Member Author

jiasli commented Jul 7, 2020

The CI result is weird:

❌ Azure.azure-cli (Automation Test (Profile Latest) Python36)
✔ Azure.azure-cli (Automation Test (Profile Latest) Python38)

❌ CLI Automation Full Test (Automation Test Python36)
❌ CLI Automation Full Test (Automation Test Python38)

The failed test is VMImageListThruServiceScenarioTest.test_vm_images_list_thru_services. The recording was updated by live-running the test again.

It passes on Windows Python 3.8.3 but fails on Linux Python 3.8.3.

        except CannotOverwriteExistingCassetteException as ex:
>           raise AssertionError(ex)
E           AssertionError: No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/publishers/canonical-test/artifacttypes/vmimage/offers?api-version=2019-07-01>) was found. Can't overwrite existing cassette ('/home/jladmin/azure-cli/src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_images_list_thru_services.yaml') in your current record mode ('once').

azure-cli/src/azure-cli-testsdk/azure/cli/testsdk/base.py:294: AssertionError

To repro, checkout the source branch and run

pytest azure-cli/src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py::VMImageListThruServiceScenarioTest::test_vm_images_list_thru_services

@qwordy, could you help take a look?

@qwordy
Copy link
Member

qwordy commented Jul 8, 2020

I am looking at it. I have reproduced this issue.

Comment on lines +67 to +68
# TODO: Sometimes fail in playback mode. Temporarily make it live only. #14292
@live_only()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address in #14292.

jiasli added 3 commits July 9, 2020 11:25
# Conflicts:
#	src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_image_build_managed_image.yaml
#	src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_image_build_shared_image.yaml
#	src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_create_existing_ids_options.yaml
#	src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_create_existing_options.yaml
#	src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_image_terms.yaml
#	src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_images_list_thru_services.yaml
@jiasli jiasli merged commit d32ceb9 into Azure:dev Jul 9, 2020
@jiasli jiasli deleted the bump-subscriptions branch July 9, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GeographyGroup is missed in az account list-locations result

4 participants