[Extension] support .egg-info to store wheel type extension metadata #13286
Conversation
haroldrandom
added
the
Extensions
|
add to S170 |
| self.assertTrue(metadata['azext.isPreview']) | ||
| self.assertTrue(metadata['azext.isExperimental']) |
There was a problem hiding this comment.
I remember these two tags are not supposed to be both True in the future. @zhoxing-ms for confirmation.
There was a problem hiding this comment.
Thanks for sharing this, I just learnt that.
I think the class WheelExtension and DevExtension is to represent data model not validation. Validation should be a higher level business.
This PR is about to test reading the metadata correctly, not validation for isExperimental and isPreview unless we decide to make validation here.
Please @jiasli make sure that the concern above has been made in CLI.
|
|
||
| ext_name, ext_version = 'hello', '0.1.0' | ||
|
|
||
| ext_extension = WheelExtension(ext_name, os.path.join(self.ext_dir, ext_name + '-' + ext_version)) |
There was a problem hiding this comment.
This is to test WheelExtension class not DevExtension.
The user using this way to develop Azure CLI extension is to hack the machenism. I think it's doable but not recommended. And supporting .egg-info is just one month ago.
4 participants
Description
As this PR #12367 pointing out, some user may manually install extension from source code and still want to load it.
Same scenario could happen in the developing of azure-cli-ml as discussed offline. The develop CLI extension without azdev, and use that way to work in editable mode in older CLI (<= 2.4.0)
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.