[Network] Enable local context feature for vnet/subnet parameter #13059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmyyrroonn
reviewed
Apr 17, 2020
| subnet_name_type = CLIArgumentType(options_list='--subnet-name', metavar='NAME', help='The subnet name.') | ||
| virtual_network_name_type = CLIArgumentType(options_list='--vnet-name', metavar='NAME', help='The virtual network (VNet) name.', completer=get_resource_name_completion_list('Microsoft.Network/virtualNetworks'), | ||
| local_context_attribute=LocalContextAttribute(name='vnet_name', actions=[GET])) | ||
| subnet_name_type = CLIArgumentType(options_list='--subnet-name', metavar='NAME', help='The subnet name.', |
Contributor
There was a problem hiding this comment.
I think we better not set default value for subnet_name. Several commands have to have specific subnet name which is defined as the default value in the custom function. Meanwhile, we used c.ignore to hide this value from customers. Will they be overwritten by local context?
Contributor
There was a problem hiding this comment.
double confirmed the logic. Should be fine.
mmyyrroonn
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is try to enable local context feature for vnet/subnet.
We will save vnet/subnet value to local context in
createcommand and use these values inupdate,showand some other commands. One exception is fordeletecommand. Fordeletecommand, user still need to specify vnet or subnet name even if local context is turned on.Testing Guide
az network vnet create -g RG -n vnetName --subnet-name subnetNameaz network vnet showaz network vnet subnet showaz network vnet subnet delete(prompt error)az network vnet delete(prompt error)az network vnet subnet delete -n subnetNameaz network vnet delete -n vnetNameHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.