[Survey] Add switch to turn off survey link #13041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
Juliehzl,
arrownj,
haroldrandom,
jiasli and
qianwens
as code owners
fengzhou-msft
commented
Apr 16, 2020
| show_link = self.cli_ctx.config.getboolean('output', 'show_survey_link', True) | ||
| if show_link: | ||
| print(SURVEY_PROMPT_COLOR if self.cli_ctx.enable_color else SURVEY_PROMPT) | ||
| if not nouns: |
Member
Author
There was a problem hiding this comment.
Only add ux link for az --help without a specific command.
jiasli
reviewed
Apr 16, 2020
| 'https://aka.ms/clihats' + Style.RESET_ALL | ||
| UX_SURVEY_PROMPT = 'Mobile developer using Azure CLI? Come try our newest feature: https://aka.ms/CLIUXstudy' | ||
| UX_SURVEY_PROMPT_COLOR = Fore.YELLOW + Style.BRIGHT + 'Mobile developer using Azure CLI? Come try our newest feature: '\ | ||
| + Fore.BLUE + 'https://aka.ms/CLIUXstudy' + Style.RESET_ALL |
Member
There was a problem hiding this comment.
https://aka.ms/CLIUXstudy seems to be a survey, instead of a feature.
jiasli
reviewed
Apr 16, 2020
| SURVEY_PROMPT_COLOR = Fore.YELLOW + Style.BRIGHT + 'Please let us know how we are doing: ' + Fore.BLUE + \ | ||
| 'https://aka.ms/clihats' + Style.RESET_ALL | ||
| UX_SURVEY_PROMPT = 'Mobile developer using Azure CLI? Come try our newest feature: https://aka.ms/CLIUXstudy' | ||
| UX_SURVEY_PROMPT_COLOR = Fore.YELLOW + Style.BRIGHT + 'Mobile developer using Azure CLI? Come try our newest feature: '\ |
Member
There was a problem hiding this comment.
Suggested change
| UX_SURVEY_PROMPT_COLOR = Fore.YELLOW + Style.BRIGHT + 'Mobile developer using Azure CLI? Come try our newest feature: '\ | |
| UX_SURVEY_PROMPT_COLOR = Fore.YELLOW + Style.BRIGHT + 'Mobile developer using Azure CLI? Come and try our newest feature: '\ |
Member
|
@fengzhou-msft let's confirm the message string with PM |
Member
Author
Message updated via PM's suggestion. |
yungezz
approved these changes
Apr 16, 2020
| 'https://aka.ms/clihats' + Style.RESET_ALL | ||
| UX_SURVEY_PROMPT = 'And let us know if you\'re interested in trying out our newest features: https://aka.ms/CLIUXstudy' | ||
| UX_SURVEY_PROMPT_COLOR = Fore.YELLOW + Style.BRIGHT + \ | ||
| 'And let us know if you\'re interested in trying out our newest features: ' \ |
fengzhou-msft
commented
Apr 16, 2020
jiasli
approved these changes
Apr 17, 2020
arrownj
reviewed
Apr 17, 2020
Contributor
arrownj
left a comment
arrownj
left a comment
There was a problem hiding this comment.
just curious about that the only way to set this setting is to update config file manually ?
Member
Author
For changing config file, you can only manually edit it. But you can also set an environment variable as described in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AZURE_OUTPUT_SHOW_SURVEY_LINK=noor add the following in~/.azure/config:The environment variable has higher priority.
az --versionandaz --help(but not inaz some-command --help).The output looks like this in
az --version:Testing Guide
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.