[ARM] az resource tag: Add parameter --is-incremental to support adding tags to resource incrementally (#12736)
#12944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
add to S168 |
Juliehzl
reviewed
Apr 17, 2020
Contributor
There was a problem hiding this comment.
I think 'store_true' may be more suitable because we will not start incremental tag by default.
Contributor
Author
There was a problem hiding this comment.
Good suggestion, changed it
zhoxing-ms
force-pushed
the
resource_tag_incremental
branch
from
2373a9d to
5e56dea
Compare
Juliehzl
reviewed
Apr 17, 2020
|
|
||
| self.cmd('resource delete --id {vault_id}', checks=self.is_empty()) | ||
|
|
||
| @ResourceGroupPreparer(name_prefix='cli_test_tag_incrementally', location='westus') |
Contributor
There was a problem hiding this comment.
I don't find incremental flag in test.
Juliehzl
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR (Mandatory)
Feature request: #12736
Testing Guide
Run
az resource tag --ids resource-id --tags new-key=new-value -iHistory Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.