{Monitor} Move antlr4-python3-runtime to src/azure-cli/setup.py #12917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmyyrroonn
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom,
jiasli and
qianwens
as code owners
jiasli
reviewed
Apr 8, 2020
src/azure-cli/setup.py
Outdated
| packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]), | ||
| install_requires=DEPENDENCIES, | ||
| extras_require={ | ||
| ":python_version<'3.0'": ['antlr4-python2-runtime'] |
Member
There was a problem hiding this comment.
We have dropped Python 2. We can safely remove this dependency. #11363
mmyyrroonn
commented
Apr 8, 2020
| ] | ||
|
|
||
| DEPENDENCIES = [ | ||
| 'antlr4-python3-runtime~=4.7.2', |
Contributor
Author
There was a problem hiding this comment.
I'm not sure. Is it the correct way to fix this issue? @fengzhou-msft Since python2 and python3 share the same namespace.
Member
There was a problem hiding this comment.
We do not support python 2 now, this is fine.
Member
There was a problem hiding this comment.
Do you have any code that may have different handlings for py2 and py3 with this antlr4 dependency? You may also clean that code if yes.
Contributor
Author
There was a problem hiding this comment.
no. They share same signature to us.
mmyyrroonn
commented
Apr 8, 2020
src/azure-cli/setup.py
Outdated
| packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]), | ||
| install_requires=DEPENDENCIES, | ||
| extras_require={ | ||
| ":python_version<'3.0'": ['antlr4-python2-runtime'] |
Contributor
Author
There was a problem hiding this comment.
maybe something like ":python_version<'3.0'": ['antlr4-python2-runtime'==4.7.2]?
Collaborator
|
add to S168 |
mmyyrroonn
changed the title
jiasli
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
antlr4 is used in monitor. We use 4.7.2 antlr4 tool to generate some codes in monitor. We still need a antlr4 runtime. But we didn't define it as a requirement in azure-cli before. In azure-cli-core, the version is not locked and the new version is 4.8.0. It would cause warning if two versions are not same.
Fix #12892
Description of PR (Mandatory)
(Why this PR? What is changed? What is the effect? etc. A high-quality description can accelerate the review process)
Testing Guide
(Example commands with explanations)
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.