{Telemetry|Feedback} add installer data#12717
Merged
fengzhou-msft merged 6 commits intoAzure:devfrom Mar 25, 2020
Merged
Conversation
Collaborator
|
Telemetry |
yungezz
approved these changes
Mar 23, 2020
Contributor
|
Why added |
jiasli
reviewed
Mar 24, 2020
Member
There was a problem hiding this comment.
The current UA is like
'User-Agent': 'python/3.8.2 (Windows-10-10.0.18362-SP0) msrest/0.6.11 msrest_azure/0.6.2 azure-mgmt-resource/8.0.1 Azure-SDK-For-Python AZURECLI/2.2.0'
Maybe we can append the content of ENV_AZ_INSTALLER to UA_AGENT and make it like AZURECLI/2.2.0 (PIP)?
This is like what Chrome does:
Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Mobile Safari/537.36
My two cents.
jiasli
reviewed
Mar 24, 2020
Comment on lines
87
to
91
Member
There was a problem hiding this comment.
The same logic is also needed by az rest:
azure-cli/src/azure-cli-core/azure/cli/core/util.py
Lines 556 to 558 in 31a9724
Maybe we can extract the header handling logic to src/azure-cli-core/azure/cli/core/util.py?
Member
There was a problem hiding this comment.
#12734 is merged. We can merge from dev and put the logic in get_az_user_agent.
b1a9080 to
fdc9a4f
Compare
jiasli
reviewed
Mar 25, 2020
Co-Authored-By: Jiashuo Li <jiasli@microsoft.com>
jiasli
approved these changes
Mar 25, 2020
haroldrandom
approved these changes
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #9013
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.