[SQL] Sql midb Add: update/show long term retention policy, show/delete long term retention backups, restore long term retention backup #12712

xaliciayang · 2020-03-23T09:09:31Z

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.

… ltr restore

yonzhan · 2020-03-23T11:34:02Z

add to S167

src/azure-cli/azure/cli/command_modules/sql/commands.py

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py

src/azure-cli/azure/cli/command_modules/sql/_params.py

src/azure-cli/azure/cli/command_modules/sql/commands.py

src/azure-cli/azure/cli/command_modules/sql/custom.py

azure-cli1.pyproj

src/azure-cli/azure/cli/command_modules/sql/_params.py

jaredmoo · 2020-03-24T21:00:33Z

I would love if the length of short-term-retention-policy can be aggressively reduced in length. Try typing this 10 times in a row and I'm sure you would not want to be a customer using this command repeatedly :) Ergonomics is more important than clarify here - abbreviations can be easily explained with help text, as has been done for sql mi, sql midb, etc. My first idea is just short-term, but there are more possibilities.

src/azure-cli/azure/cli/command_modules/sql/_help.py

src/azure-cli/azure/cli/command_modules/sql/_params.py

src/azure-cli/azure/cli/command_modules/sql/_help.py

src/azure-cli/azure/cli/command_modules/sql/commands.py

Juliehzl

Please add checks for all your test commands to make sure commands output is as expected.

…ecord

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py

src/azure-cli/azure/cli/command_modules/sql/custom.py

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py

src/azure-cli/azure/cli/command_modules/sql/_params.py

…dded is_preview=True to new commands; added ability to use int arguments to configure retention settings in days

xaliciayang added 4 commits March 21, 2020 23:33

added ltr mi policy to commands/params

de11560

add custom commands/params for ltr mi backup APIs; updated params for…

3d2172d

… ltr restore

added LTR Policy tests

197c900

fixing pylint

7fca0f7

xaliciayang requested review from Juliehzl and jaredmoo as code owners March 23, 2020 09:09

yungezz assigned arrownj Mar 23, 2020

yonzhan added this to the S167 milestone Mar 23, 2020

yonzhan requested a review from qianwens March 23, 2020 11:34

arrownj reviewed Mar 23, 2020

View reviewed changes

fix pylint

233c779

pixia reviewed Mar 23, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/custom.py Outdated Show resolved Hide resolved

pixia reviewed Mar 23, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/custom.py Outdated Show resolved Hide resolved

xaliciayang added 3 commits March 23, 2020 17:38

updated commands

8932742

fix setting location for ltr restore

0887b12

adding test cases for all LTR MI functions

32bdfd3

xaliciayang changed the title ~~LTR for MI tests~~ [SQL] Add commands to support long term retention for Managed Databases Mar 24, 2020

removing unrelated files

756738c

pixia reviewed Mar 24, 2020

View reviewed changes

azure-cli1.pyproj Outdated Show resolved Hide resolved

pixia reviewed Mar 24, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/_params.py Outdated Show resolved Hide resolved

pixia reviewed Mar 24, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/_params.py Outdated Show resolved Hide resolved

xaliciayang added 2 commits March 24, 2020 17:06

added help, some fixes to parameters

59e19c4

edit test cases

9f9aee5

xaliciayang changed the title ~~[SQL] Add commands to support long term retention for Managed Databases~~ [SQL] Sql midb Add: update/show long term retention policy, show/delete long term retention backups, restore long term retention backup Mar 25, 2020

xaliciayang added 4 commits March 25, 2020 02:53

removed print line

e3a393d

removing unneeded files; removing whitespace fixes

0ec14bb

whitespace fixing; adding some details to params

3f45a78

updating help/params, some typos

bd9f71c

jaredmoo reviewed Apr 9, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/_help.py Outdated Show resolved Hide resolved

jaredmoo reviewed Apr 9, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/_params.py Show resolved Hide resolved

xaliciayang added 4 commits April 9, 2020 17:23

remove whitespace

9493d8e

changed --name to represent backup name in ltr-backup commands

204b6fb

added lines for style

7452420

fix help

f9d22b3

jaredmoo approved these changes Apr 10, 2020

View reviewed changes

update week_of_year help

bc782bd

Juliehzl reviewed Apr 14, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/_help.py Outdated Show resolved Hide resolved

Juliehzl reviewed Apr 14, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/commands.py Outdated Show resolved Hide resolved

Juliehzl requested changes Apr 14, 2020

View reviewed changes

add \ to help; add confirmation for delete; add checks in tests; re-r…

0be376f

…ecord

Juliehzl reviewed Apr 15, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py Show resolved Hide resolved

Juliehzl reviewed Apr 15, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py Outdated Show resolved Hide resolved

Juliehzl reviewed Apr 15, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py Show resolved Hide resolved

xaliciayang requested a review from Juliehzl April 15, 2020 08:47

xaliciayang added 4 commits April 16, 2020 00:16

enable ltr-backup show to accept backup-id

96c6b3a

enable delete with backup_id

35badd4

adjust usage of --latest in test

fb05415

remove py files

7898a1d