Skip to content

[Packaging] drop support for python 3.5 #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengzhou-msft merged 1 commit into from
Mar 25, 2020
Merged

[Packaging] drop support for python 3.5 #12694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/command_guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ Virtual Network Rule Arguments

## Coding Practices

- All code must support Python 3.5, 3.6, 3.7 and 3.8
- All code must support Python 3.6, 3.7 and 3.8
- PRs to Azure/azure-cli and Azure/azure-cli-extensions must pass CI
- Code must pass style checks with pylint and pep8
- (*) All commands should have tests
2 changes: 1 addition & 1 deletion doc/debug/debug_in_vs_code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

* Visual Studio Code [Link](http://code.visualstudio.com/)
* Visual Studio Code Python Extension [Link](https://marketplace.visualstudio.com/items?itemName=donjayamanne.python)
* Python 3.5+
* Python 3.6+
* Set up development environment [Link](https://github.com/Azure/azure-cli/blob/master/doc/configuring_your_machine.md)

## Quick start
Expand Down
2 changes: 1 addition & 1 deletion doc/extensions/authoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ See [Extension Metadata](metadata.md) for more information.

### Test your extension on Python 3

- The CLI supports Python 3.5, 3.6, 3.7, 3.8 so verify that your extension does the same.
- The CLI supports Python 3.6, 3.7, 3.8 so verify that your extension does the same.
- You can create virtual environments for different versions and run your extension in them.
- e.g. `python3.6 -m venv env36` and `python3.8 -m venv env38`.

Expand Down
22 changes: 11 additions & 11 deletions doc/install_linux_prerequisites.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Some native Linux packages are required when installing the CLI with:
- Interactive install script
- ``pip``

Current supported Python versions are Python 3.5, 3.6, 3.7, 3.8. Azure CLI packages prior to version 2.1.0 support both Python 2.7 and Python 3.
Current supported Python versions are Python 3.6, 3.7, 3.8. Azure CLI packages prior to version 2.1.0 support both Python 2.7 and Python 3.

The commands to run to install the dependencies for some common distributions are listed below.

Expand All @@ -28,19 +28,19 @@ The commands to run to install the dependencies for some common distributions ar
* [CoreOS](#coreos-stable-899150--beta-101010--alpha-101010)

### Ubuntu 12.04 LTS
Python 2.7.3 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.3 should be already on the machine. Install Python 3.6+ if needed.
```
sudo apt-get update && sudo apt-get install -y libssl-dev libffi-dev python-dev
```

### Ubuntu 14.04 LTS and BASH on Windows (Build 14362+)
Python 2.7.6 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.6 should be already on the machine. Install Python 3.6+ if needed.
```
sudo apt-get update && sudo apt-get install -y libssl-dev libffi-dev python-dev
```

### Ubuntu 15.10
Python 2.7.10 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.10 should be already on the machine. Install Python 3.6+ if needed.
```
sudo apt-get update && sudo apt-get install -y libssl-dev libffi-dev python-dev build-essential
```
Expand All @@ -56,39 +56,39 @@ sudo apt-get update && sudo apt-get install -y libssl-dev libffi-dev python-dev
```

### Debian 7
Python 2.7.3 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.3 should be already on the machine. Install Python 3.6+ if needed.
```
sudo apt-get update && sudo apt-get install -y libssl-dev libffi-dev python-dev
```

### Debian 8
Python 2.7.9 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.9 should be already on the machine. Install Python 3.6+ if needed.
```
sudo apt-get update && sudo apt-get install -y libssl-dev libffi-dev python-dev build-essential
```

### CentOS 6.5 / 6.6 / 6.7

Not supported with the default version of Python (2.6.6) on the machine. Install Python 3.5+ if needed.
Not supported with the default version of Python (2.6.6) on the machine. Install Python 3.6+ if needed.

### CentOS 7.1 / 7.2
Python 2.7.5 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.5 should be already on the machine. Install Python 3.6+ if needed.
```
sudo yum check-update; sudo yum install -y gcc libffi-devel python-devel openssl-devel
```

### RedHat RHEL 6.7

Not supported with the default version of Python (2.6.6) on the machine. Install Python 3.5+ if needed.
Not supported with the default version of Python (2.6.6) on the machine. Install Python 3.6+ if needed.

### RedHat RHEL 7.2
Python 2.7.5 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.5 should be already on the machine. Install Python 3.6+ if needed.
```
sudo yum check-update; sudo yum install -y gcc libffi-devel python-devel openssl-devel
```

### SUSE OpenSUSE 13.2
Python 2.7.8 should be already on the machine. Install Python 3.5+ if needed.
Python 2.7.8 should be already on the machine. Install Python 3.6+ if needed.
```
sudo zypper refresh && sudo zypper --non-interactive install gcc libffi-devel python-devel openssl-devel
```
Expand Down
3 changes: 0 additions & 3 deletions scripts/ci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,7 @@ CLASSIFIERS = [
'Development Status :: 3 - Alpha',
'Intended Audience :: Developers',
'Programming Language :: Python',
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down
3 changes: 0 additions & 3 deletions src/azure-cli-command_modules-nspkg/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@
'Intended Audience :: Developers',
'Intended Audience :: System Administrators',
'Programming Language :: Python',
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
'Intended Audience :: System Administrators',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli-nspkg/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
'Intended Audience :: System Administrators',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli-telemetry/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
'Intended Audience :: System Administrators',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli-testsdk/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
'Intended Audience :: Developers',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down
4 changes: 0 additions & 4 deletions src/azure-cli/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
'Intended Audience :: System Administrators',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand Down Expand Up @@ -154,9 +153,6 @@
with open('HISTORY.rst', 'r', encoding='utf-8') as f:
HISTORY = f.read()

if sys.version_info < (3, 4):
Copy link
Contributor

@bim-msft bim-msft Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why just remove this statement instead of changing it to if sys.version_info < (3, 6)?

Copy link
Member

@jiasli jiasli Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question.

Copy link
Member Author

@fengzhou-msft fengzhou-msft Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check was added in this PR. Adding this sets the hard limit for python versions at installation and block lower verisons. When we remove a version from the classifier, we're droppiong support for that version. It doesn't mean the code must not be compatible with that version. We can remove python 3.6 simply becaused it reaches end-of-life in the future, but our CLI code could still be totally compatible with python 3.6 at that time until at one point it's not. We will not fix it as we stated it's not supported.

Copy link
Contributor

@bim-msft bim-msft Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengzhou-msft I think I got your point, thanks for the clarification.

raise ImportError("azure-cli requires Python 3.4 or later.")

setup(
name='azure-cli',
version=VERSION,
Expand Down
5 changes: 0 additions & 5 deletions tools/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# --------------------------------------------------------------------------------------------

from setuptools import setup
import sys

VERSION = "0.1.1"

Expand All @@ -14,7 +13,6 @@
'Intended Audience :: System Administrators',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Expand All @@ -36,9 +34,6 @@
'colorama>=0.3.7'
]

if sys.version_info < (3, 4):
raise ImportError("azure-cli requires Python 3.4 or later.")

setup(
name='azure-cli-dev-tools',
version=VERSION,
Expand Down