[Iot Central] az iotcentral deprecated #12681

r-delgadillo · 2020-03-20T06:56:17Z

History Notes

[IoT Central] Deprecate az iotcentral
[IoT Central] Add az iot central command module

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.

yungezz · 2020-03-20T08:07:45Z

HI @fengzhou-msft could you pls help to review the PR? thanks.

yonzhan · 2020-03-20T15:15:37Z

iotcentral

src/azure-cli/azure/cli/command_modules/iot/_params.py

src/azure-cli/azure/cli/command_modules/iot/commands.py

src/azure-cli/azure/cli/command_modules/iot/custom.py

fengzhou-msft · 2020-03-21T14:07:36Z

Please run azdev style iot to fix the style issue and run azdev test iot --live (add --discover for first run) to run live tests and add recording files.

r-delgadillo · 2020-03-24T23:47:51Z

@fengzhou-msft During this experience, I had recommended to my team that I feel it's odd that we are putting control plane operations at a 4th level. For example, az iot central app create instead of something like az iot central create or az iot app create. Do you have any recommendations or guidance on which would provide a more develop friendly experience to our customers?

I read the general guidance docs but we'd like to get some insights from a member of the Azure CLI team.

r-delgadillo · 2020-03-25T00:12:43Z

Please run azdev style iot to fix the style issue and run azdev test iot --live (add --discover for first run) to run live tests and add recording files.

@fengzhou-msft I ran azdev style and test locally and pushed the changes but "checks" are still failing for test failures. I ran azdev test iot --live and they all passed when I ran them. DO you know what might be causing them to fail on the PR?

src/azure-cli/azure/cli/command_modules/iotcentral/tests/latest/test_iotcentral_commands.py

src/azure-cli/azure/cli/command_modules/iot/_help.py

fengzhou-msft · 2020-03-25T15:38:50Z

Please run azdev style iot to fix the style issue and run azdev test iot --live (add --discover for first run) to run live tests and add recording files.

@fengzhou-msft I ran azdev style and test locally and pushed the changes but "checks" are still failing for test failures. I ran azdev test iot --live and they all passed when I ran them. DO you know what might be causing them to fail on the PR?

Can you check if you commited the latest recording files after your successful live run?

…elgadillo/azure-cli into rodelga/iotcentral/deprecate

r-delgadillo · 2020-04-13T20:48:22Z

@fengzhou-msft Can we get this merged in. Thank you

src/azure-cli/HISTORY.rst

r-delgadillo · 2020-04-14T15:16:59Z

May I know why there are some deletions in src/azure-cli/azure/cli/command_modules/iot/tests/latest/recordings/test_iot_hub.yaml?

I don't believe there's any deletion. I ran the tests according to the documentation with azdev test iot --discover --live and all the tests passed.

r-delgadillo · 2020-04-14T15:18:00Z

@Juliehzl @haroldrandom Can you please take a look at the PR and merge if it's ok. Thank you

src/azure-cli/azure/cli/command_modules/iot/_help.py

Juliehzl · 2020-04-15T07:12:40Z

src/azure-cli/azure/cli/command_modules/iot/_params.py

+                   help='Pricing tier for IoT Central applications. Default value is ST2.')
+        c.argument('subdomain',
+                   help='Subdomain for the IoT Central URL. Each application must have a unique subdomain.')
+        c.argument('template',


Are there allowed values for template?

Yes, there is. We have an API that allows customers to see the available options.

We do not want to hardcode these values in the Azure CLI

In this way can we put the API in help message? Because for me (a new user), I totally don't know which value is available for template.

Yeah, I can see how that can be confusing. We have an item in our backlog to rewrite the documentation for Swagger and Az CLI. I added some details about the issue of not seeing available templates so we can address it when we have the capacity.

Juliehzl · 2020-04-15T07:13:07Z

src/azure-cli/azure/cli/command_modules/iot/commands.py

+        g.custom_show_command('show', 'iot_central_app_get')
+        g.generic_update_command('update', getter_name='iot_central_app_get',
+                                 setter_name='iot_central_app_update', command_type=update_custom_util)
+        g.custom_command('delete', 'iot_central_app_delete')


Please add confirmation=True for delete command.

I reverted this change because this will break existing scripts customers are using. This will require them to pass in --yes in order for it proceeds with existing functionality we had before.

Additionally, we really don't want to introduce any new functionality in this PR we just want to migrate existing command module code from iotcentral to iot

Have you add deprecation information for original commands? And because you already give users breaking change, and they need to change the scripts anyway, it should be fine to add one more -y in their scripts.

Please feel free to let me know your concern.

Yes, the deprecation information for az iotcentral command module is in ~/command_modules/iotcentral/commands.py in this PR. That makes sense about breaking them either way, I added it back thanks.

src/azure-cli/azure/cli/command_modules/iot/_help.py

src/azure-cli/azure/cli/command_modules/iot/commands.py

Deprecate 'iotcentral' and use 'iot central'

403f4b6

r-delgadillo changed the title ~~[Iot Central] (BREAKING CHANGE:) (az iotcentral) Deprecate 'az iotcentral' and being using 'az iot central'~~ [Iot Central] BREAKING CHANGE: az iotcentral Deprecate 'az iotcentral' and being using 'az iot central' Mar 20, 2020

r-delgadillo changed the title ~~[Iot Central] BREAKING CHANGE: az iotcentral Deprecate 'az iotcentral' and being using 'az iot central'~~ [Iot Central] BREAKING CHANGE: az iotcentral deprecated Mar 20, 2020

yungezz assigned fengzhou-msft Mar 20, 2020

yungezz added this to the S167 milestone Mar 20, 2020

yungezz added the IoTCentral label Mar 20, 2020

yungezz requested a review from fengzhou-msft March 20, 2020 08:07

fengzhou-msft reviewed Mar 21, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/_params.py Outdated Show resolved Hide resolved

fengzhou-msft reviewed Mar 21, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/commands.py Outdated Show resolved Hide resolved

fengzhou-msft reviewed Mar 21, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/custom.py Outdated Show resolved Hide resolved

rodelga added 6 commits March 23, 2020 19:49

lint

4a4c31d

Merge branch 'dev' into rodelga/iotcentral/deprecate

36b2bff

Update help sku value

6c54206

Use show_custom_command for 'show' command

41ee366

Update method comments

a1ae112

linting, run tests

b9a4dd2

r-delgadillo requested review from Juliehzl and haroldrandom as code owners March 24, 2020 19:13

record tests

84db750

r-delgadillo closed this Mar 25, 2020

r-delgadillo reopened this Mar 25, 2020

kawayiboy reviewed Mar 25, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iotcentral/tests/latest/test_iotcentral_commands.py Show resolved Hide resolved

poanchen reviewed Mar 25, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/_help.py Show resolved Hide resolved

poanchen approved these changes Mar 25, 2020

View reviewed changes

r-delgadillo requested review from arrownj, jiasli and qianwens as code owners April 10, 2020 19:45

rodelga added 3 commits April 10, 2020 12:47

sync with dev

a5cd185

Merge branch 'rodelga/iotcentral/deprecate' of https://github.com/r-d…

82395cb

…elgadillo/azure-cli into rodelga/iotcentral/deprecate

run test

d588253

r-delgadillo changed the title ~~[DO NOT MERGE] [Iot Central] az iotcentral deprecated~~ [Iot Central] az iotcentral deprecated Apr 13, 2020

fengzhou-msft reviewed Apr 14, 2020

View reviewed changes

src/azure-cli/HISTORY.rst Outdated Show resolved Hide resolved

fengzhou-msft approved these changes Apr 14, 2020

View reviewed changes

Remove History comments

6c42022

Juliehzl reviewed Apr 15, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/_help.py Outdated Show resolved Hide resolved

Juliehzl reviewed Apr 15, 2020

View reviewed changes

rodelga added 4 commits April 15, 2020 08:39

Add confirmation message for deleteing an application

3443795

Revert confirmation

56cd739

Add confirmation

5d5a3d7

remove text from help file

7c99b10

Juliehzl reviewed Apr 17, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/_help.py Outdated Show resolved Hide resolved

Juliehzl reviewed Apr 17, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/commands.py Outdated Show resolved Hide resolved

Juliehzl added 2 commits April 17, 2020 10:27

Update src/azure-cli/azure/cli/command_modules/iot/_help.py

b0ac719

Update src/azure-cli/azure/cli/command_modules/iot/commands.py

7ed1bb5

Juliehzl approved these changes Apr 17, 2020

View reviewed changes

Juliehzl reviewed Apr 17, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/iot/commands.py Outdated Show resolved Hide resolved

Juliehzl added 2 commits April 17, 2020 10:55

Update src/azure-cli/azure/cli/command_modules/iot/commands.py

0696aa2

fix style

4c9c6b2

Juliehzl merged commit 0b3b6bb into Azure:dev Apr 17, 2020

zhoxing-ms mentioned this pull request May 10, 2023

Please fix IoT Summary page #26305

Closed

[Iot Central] az iotcentral deprecated #12681

[Iot Central] az iotcentral deprecated #12681

Uh oh!

Conversation

r-delgadillo commented Mar 20, 2020 • edited by fengzhou-msft Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungezz commented Mar 20, 2020

Uh oh!

yonzhan commented Mar 20, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengzhou-msft commented Mar 21, 2020

Uh oh!

r-delgadillo commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r-delgadillo commented Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengzhou-msft commented Mar 25, 2020

Uh oh!

r-delgadillo commented Apr 13, 2020

Uh oh!

Uh oh!

r-delgadillo commented Apr 14, 2020

Uh oh!

r-delgadillo commented Apr 14, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Juliehzl Apr 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r-delgadillo Apr 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

r-delgadillo commented Mar 20, 2020 •

edited by fengzhou-msft

Loading

r-delgadillo commented Mar 24, 2020 •

edited

Loading

r-delgadillo commented Mar 25, 2020 •

edited

Loading

Juliehzl Apr 16, 2020 •

edited

Loading

r-delgadillo Apr 16, 2020 •

edited

Loading