Add Kubernetes support to ACS.

[brendandburns]

@yugang-msft

Thanks!
--brendan

[yugangw-msft]

Please fix pylint errors and get CI green. Also clarify review comments.

[yugangw-msft]

please delete this line, as this is a duplicate of 3 lines above

[brendandburns]

done.

[yugangw-msft]

Consider to exposing the version like you did for dcos. Up to you at this moment though

[brendandburns]

done.

[yugangw-msft]

use sys.stdout.write just be consistent?

[brendandburns]

I prefer print for it's platform indepdent newline.

[derekbekoe]

mgmt_acs should be moved into this command module rather than the acs module having a dependency on vm.

[yugangw-msft]

@derekbekoe, this will be cleaned up in 2 weeks per conversation with Brendan

[brendandburns]

ack. I promise to fix this asap, but I need to get this in for the 11/11 cut.

Thanks for the flexibility.

[yugangw-msft]

More pylint errors to clean up

[yugangw-msft]

this change is unnecessary and might well cause a pylint errir

[brendandburns]

done.

[yugangw-msft]

For your consideration, azure-cli commands use password terminology across for this concept. For consistency I would suggest you use the password here. Both terminologies are correct, but have used at different layers.
At this point it is your call, because you have to update related method as well

[yugangw-msft]

@brendandburns , other than pylint error, you should take a look at the test failure of acs create particularly the command no longer return the 3 pieces of information to user such as masterFQDN, agentFQDN, and ssh command. So you probably should incorporate the output artifacts from the quick start template. Please chat with @sauryadas for more context

[brendandburns]

@yugangw-msft I actually see that output in the example output that the JMESPath assertion is testing. I'm really not certain why the query isn't picking it up.

Is there a quick way to just run that one test?

Thanks
--brendan

[yugangw-msft]

@brendandburns, can you paste the output of the create ?
I know the cause, please refer to my later comment below

[yugangw-msft]

@brendandburns, yes you can run that test:

python -m unittest azure.cli.command_modules.vm.tests.test_vm_commands.AzureContainerServiceScenarioTest.test_acs_create_update 

and to fix the test (assume you have communicated with @sauryadas), is to use fully qualified property path such as properties.outputs.masterFQDN.value. The reason for the change is the command now outputs the full blown object, rather the old customized slimmed down version

[yugangw-msft]

@brendandburns,
For JMESPATH in test, please ensure to point to "properties.outputs.masterFQDN.value"
For pylints error on using print, you should put ‘from future import print_function’ at the top

[derekbekoe]

PR #1059 has been merged so a rebase will be required with a couple of changes to the acs/commands.py and vm/commands.py files.

Changes required in acs/commands.py:

• Remove the from .custom (...) import statements.
• Change command registration (see snippets)

cli_command('acs create', acs_create)
cli_command('acs kubernetes install-cli', k8s_install_cli)
cli_command('acs kubernetes get-credentials', acs_get_credentials)

Would change to:

cli_command(__name__, 'acs create', 'azure.cli.command_modules.acs.custom#acs_create')
cli_command(__name__, 'acs kubernetes install-cli', 'azure.cli.command_modules.acs.custom#k8s_install_cli')
cli_command(__name__, 'acs kubernetes get-credentials', 'azure.cli.command_modules.acs.custom#get')

Changes required for the vm/commands.py conflict:

• Remove the registration of the acs create command from this file.
• In vm/_client_factory.py, remove the method cf_acs_create()

[brendandburns]

@derekbekoe yep, I made that refactor, ptal.

thanks!
--brendan