Skip to content

[Storage] az storage container immutability create: add --allow-protected-append-write parameter #12448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juliehzl merged 1 commit into from
Mar 5, 2020
Merged

[Storage] az storage container immutability create: add --allow-protected-append-write parameter #12448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/azure-cli/azure/cli/command_modules/storage/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,10 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem
with self.argument_context('storage container exists') as c:
c.ignore('blob_name', 'snapshot')

with self.argument_context('storage container immutability-policy') as c:
c.argument('allow_protected_append_writes', options_list=['--allow-protected-append-writes', '-w'],
arg_type=get_three_state_flag())

with self.argument_context('storage container list') as c:
c.argument('num_results', arg_type=num_results_type)

Expand Down
369 changes: 119 additions & 250 deletions ...i/azure/cli/command_modules/storage/tests/latest/recordings/test_immutability_policy.yaml
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 15 additions & 10 deletions ...re/cli/command_modules/storage/tests/latest/test_storage_container_immutability_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,34 +9,39 @@

class StorageImmutabilityPolicy(ScenarioTest):
@ResourceGroupPreparer()
def test_immutability_policy(self, resource_group):
storage_account = self.create_random_name('clistorage', 20)
self.cmd('storage account create -g {} -n {} --kind StorageV2'.format(
resource_group, storage_account))
@StorageAccountPreparer(kind="StorageV2")
def test_immutability_policy(self, resource_group, storage_account):
container_name = 'container1'
self.cmd('storage container create --account-name {} -n {}'.format(storage_account, container_name))

self.cmd('az storage container immutability-policy create --account-name {} -c {} -g {} --period 1'.format(
self.cmd('az storage container immutability-policy create --account-name {} -c {} -g {} --period 1 -w'.format(
storage_account, container_name, resource_group), checks=[
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1)])
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1),
JMESPathCheck('allowProtectedAppendWrites', True)
])

policy_etag = self.cmd('az storage container immutability-policy show --account-name {} -c {} -g {}'.format(
storage_account, container_name, resource_group), checks=[
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1)]).get_output_in_json().get('etag')
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1),
JMESPathCheck('allowProtectedAppendWrites', True)
]).get_output_in_json().get('etag')

self.cmd('az storage container immutability-policy delete --account-name {} -c {} -g {} --if-match {}'.format(
storage_account, container_name, resource_group, repr(policy_etag)))

self.cmd('az storage container immutability-policy show --account-name {} -c {} -g {}'.format(
storage_account, container_name, resource_group))

self.cmd('az storage container immutability-policy create --account-name {} -c {} -g {} --period 1'.format(
self.cmd('az storage container immutability-policy create --account-name {} -c {} -g {} --period 1 -w false'.format(
storage_account, container_name, resource_group), checks=[
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1)])
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1),
JMESPathCheck('allowProtectedAppendWrites', False)])

policy_etag = self.cmd('az storage container immutability-policy show --account-name {} -c {} -g {}'.format(
storage_account, container_name, resource_group), checks=[
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1)]).get_output_in_json().get('etag')
JMESPathCheck('immutabilityPeriodSinceCreationInDays', 1),
JMESPathCheck('allowProtectedAppendWrites', False)
]).get_output_in_json().get('etag')

self.cmd('az storage container immutability-policy lock --account-name {} -c {} -g {} --if-match {}'.format(
storage_account, container_name, resource_group, repr(policy_etag)))
Expand Down