Skip to content

{Packaging} bump up pyyaml #12440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengzhou-msft merged 2 commits into from
Mar 6, 2020
Merged

{Packaging} bump up pyyaml #12440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6f79e
bump pyyaml to 5.3
fengzhou-msft Mar 4, 2020
085cbfd
relax the version in setup
fengzhou-msft Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
'paramiko>=2.0.8,<3.0.0',
'PyJWT',
'pyopenssl>=17.1.0', # https://github.com/pyca/pyopenssl/pull/612
'pyyaml',
'pyyaml~=5.2',
'requests~=2.20',
'six~=1.12',
'wheel==0.30.0',
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Darwin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ PyNaCl==1.3.0
pyOpenSSL==19.0.0
python-dateutil==2.8.0
pytz==2019.1
PyYAML==5.1.1
PyYAML==5.3
requests==2.22.0
requests-oauthlib==1.2.0
scp==0.13.2
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ PyNaCl==1.3.0
pyOpenSSL==19.0.0
python-dateutil==2.8.0
pytz==2019.1
PyYAML==5.1.1
PyYAML==5.3
requests==2.22.0
requests-oauthlib==1.2.0
scp==0.13.2
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.windows.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ pyreadline==2.1
python-dateutil==2.8.0
pytz==2019.1
pywin32==225
PyYAML==5.1.1
PyYAML==5.3
requests==2.22.0
requests-oauthlib==1.2.0
scp==0.13.2
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
'pygments~=2.4',
'pyOpenSSL>=17.1.0',
'pytz==2019.1',
'pyyaml~=5.1',
'pyyaml~=5.2',
Copy link
Member

@jiasli jiasli Mar 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sync the version to 5.3. Or we may remove the version lock in setup.py files.

Copy link
Member Author

@fengzhou-msft fengzhou-msft Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For setup.py, we should relax the version to be the lowest workable version. Since version 5.1 through 5.1.2 have the reported critical security issue, so I think we can put 5.2.

For requiements, any workable version is fine. I think we can put the latest one for testing purpose.

'requests~=2.22',
'scp~=0.13.2',
'six~=1.12',
Expand Down
2 changes: 1 addition & 1 deletion tools/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
'nose>=1.3.7',
'readme_renderer>=17.2',
'requests',
'pyyaml',
'pyyaml~=5.2',
'knack',
'six>=1.10.0',
'tabulate>=0.7.7',
Expand Down