Skip to content

[ARM] az deployment validate: Fix the exit code when the verification fails (#12031) #12286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhoxing-ms wants to merge 1 commit into from
Closed

[ARM] az deployment validate: Fix the exit code when the verification fails (#12031) #12286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/azure-cli/azure/cli/command_modules/resource/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,10 @@ def _deploy_arm_template_unmodified(cli_ctx, resource_group_name, template_file=
)

if validate_only:
return sdk_no_wait(no_wait, deployments_operation_group.validate, resource_group_name, deployment_name, properties)
response = sdk_no_wait(no_wait, deployments_operation_group.validate, resource_group_name, deployment_name, properties)
if response and response.error:
raise CLIError(response.error)
return response
return sdk_no_wait(no_wait, deployments_operation_group.create_or_update, resource_group_name, deployment_name, properties)


Expand Down Expand Up @@ -469,8 +472,11 @@ def _deploy_arm_template_subscription_scope_unmodified(cli_ctx,
)

if validate_only:
return sdk_no_wait(no_wait, smc.deployments.validate_at_subscription_scope,
deployment_name, properties, deployment_location)
response = sdk_no_wait(no_wait, smc.deployments.validate_at_subscription_scope,
deployment_name, properties, deployment_location)
if response and response.error:
raise CLIError(response.error)
return response
return sdk_no_wait(no_wait, smc.deployments.create_or_update_at_subscription_scope,
deployment_name, properties, deployment_location)

Expand Down Expand Up @@ -505,8 +511,11 @@ def _deploy_arm_template_subscription_scope(cli_ctx,

smc = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_RESOURCE_RESOURCES)
if validate_only:
return sdk_no_wait(no_wait, smc.deployments.validate_at_subscription_scope,
deployment_name, properties, deployment_location)
response = sdk_no_wait(no_wait, smc.deployments.validate_at_subscription_scope,
deployment_name, properties, deployment_location)
if response and response.error:
raise CLIError(response.error)
return response
return sdk_no_wait(no_wait, smc.deployments.create_or_update_at_subscription_scope,
deployment_name, properties, deployment_location)

Expand Down
Loading