Skip to content

[AppService] Fix #2258: Fixing issue where trying to create a webapp with certain runtimes was failing #12260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panchagnula merged 3 commits into from
Feb 21, 2020
Merged

[AppService] Fix #2258: Fixing issue where trying to create a webapp with certain runtimes was failing #12260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48b348b
Fixing issue where trying to create a webapp with certain runtimes wa…
panchagnula Feb 19, 2020
03ba18e
Adding test & re-recording
panchagnula Feb 20, 2020
6659a0c
Removing the formatting changes to keep the changes to just the bug fix
panchagnula Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/azure-cli/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
Release History
===============

**AppService**
az webapp create : Fixing issue when running the command with --runtime

2.1.0
++++++

Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def create_webapp(cmd, resource_group_name, name, plan, runtime=None, startup_fi
match = helper.resolve(runtime)
if not match:
raise CLIError("Runtime '{}' is not supported. Please invoke 'list-runtimes' to cross check".format(runtime)) # pylint: disable=line-too-long
match['setter'](cmd, match, site_config)
match['setter'](cmd=cmd, stack=match, site_config=site_config)
# Be consistent with portal: any windows webapp should have this even it doesn't have node in the stack
if not match['displayName'].startswith('node'):
site_config.app_settings.append(NameValuePair(name="WEBSITE_NODE_DEFAULT_VERSION",
Expand Down Expand Up @@ -2189,7 +2189,7 @@ def stacks(self):
return self._stacks

@staticmethod
def update_site_config(stack, site_config):
def update_site_config(stack, site_config, cmd=None):
for k, v in stack['configs'].items():
setattr(site_config, k, v)
return site_config
Expand Down
Loading