-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Eventhub] Azure Stack support for 2019-03-01-hybrid profile #12113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qianwens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
add to S165. |
| azure-mgmt-devtestlabs==2.2.0 | ||
| azure-mgmt-dns==2.1.0 | ||
| azure-mgmt-eventgrid==2.2.0 | ||
| azure-mgmt-eventhub==2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember you mentioning that CLI already consume the multi api event hub pacakge. In that case do we need to update the version? @Juliehzl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case there are new features in the latest version. Upgrading the python package has no effect on the existing commands because there is no change for api version.
| # API versions | ||
| ResourceType.MGMT_APPSERVICE: '2018-02-01' | ||
| ResourceType.MGMT_APPSERVICE: '2018-02-01', | ||
| ResourceType.MGMT_EVENTHUB: '2017-04-01' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope adding the api version here does NOT mandate , adding the api version to the latest profile as well. pls confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest profile already has the same definition. Please see https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/profiles/_shared.py#L151
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
Fix #12068
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.