Skip to content

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Feb 10, 2020

History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)

[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.


Fix #12068

This checklist is used to make sure that common guidelines for a pull request are followed.

@Juliehzl Juliehzl self-assigned this Feb 10, 2020
Copy link
Member

@qianwens qianwens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonzhan yonzhan added this to the S165 milestone Feb 10, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 10, 2020

add to S165.

azure-mgmt-devtestlabs==2.2.0
azure-mgmt-dns==2.1.0
azure-mgmt-eventgrid==2.2.0
azure-mgmt-eventhub==2.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you mentioning that CLI already consume the multi api event hub pacakge. In that case do we need to update the version? @Juliehzl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case there are new features in the latest version. Upgrading the python package has no effect on the existing commands because there is no change for api version.

# API versions
ResourceType.MGMT_APPSERVICE: '2018-02-01'
ResourceType.MGMT_APPSERVICE: '2018-02-01',
ResourceType.MGMT_EVENTHUB: '2017-04-01'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope adding the api version here does NOT mandate , adding the api version to the latest profile as well. pls confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Juliehzl Juliehzl requested a review from bganapa February 11, 2020 03:18
@Juliehzl Juliehzl merged commit 7985967 into Azure:dev Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include Eventhub part of the azurestack profile 2019-03-01-hybrid

9 participants