{Network} Bump to azure-mgmt-network 9.0.0 #12078
Conversation
There was a problem hiding this comment.
azure.mgmt.network.v2019_11_01.models._models_py3.ErrorResponseException: (UnsupportedStorageAccountVersionWithRetention) Storage /subscripti
ons/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_nw_flow_logfrumyb6ki53obj262ik24kxqlqatgydxxqj3sgia37ogd7jlcqxxdjq/providers/Microsoft.S
torage/storageAccounts/clitestnwenwnk7nks5dumov is a V1 storage account and with retention policy. Only V2 storage account are supported with retention p
olicy. Read more -> aka.ms/LogsHelp
Out of dated way to configure flow-log of watcher. There must be changes on service to restrict only V2 to configure a flow-log instead the original V1.
There was a problem hiding this comment.
azure.mgmt.network.v2019_11_01.models._models_py3.ErrorResponseException: (UnsupportedStorageAccountVersionWithRetention) Storage /subscripti
ons/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_nw_flow_logfrumyb6ki53obj262ik24kxqlqatgydxxqj3sgia37ogd7jlcqxxdjq/providers/Microsoft.S
torage/storageAccounts/clitestnwenwnk7nks5dumov is a V1 storage account and with retention policy. Only V2 storage account are supported with retention p
olicy. Read more -> aka.ms/LogsHelp
Out of dated way to configure flow-log of watcher. There must be changes on service to restrict only V2 to configure a flow-log instead the original V1.
|
add to S165. |
|
/azp run |
|
Pull request contains merge conflicts. |
| accept-language: | ||
| - en-US | ||
| method: PUT | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/NetworkWatcherRG/providers/Microsoft.Network/networkWatchers/NetworkWatcher_westcentralus/connectionMonitors/cm1?api-version=2019-06-01 | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/NetworkWatcherRG/providers/Microsoft.Network/networkWatchers/NetworkWatcher_westcentralus/connectionMonitors/cm1?api-version=2019-11-01 | ||
| response: |
There was a problem hiding this comment.
FYI.
The API version is manually updated, and this is not a valid command's output.
Because some changes are made.
CMv1 is only allow to be created with api-version <= 2019-06-01, CMv2 is only allow to be created with api-version >209-06-01.
from now on, in this PR, only CMv1 is supported, CMv2 is at extensions, which will be brought in soon. So here manually update api-version to make it right.
haroldrandom
requested review from
Juliehzl,
bim-msft,
fengzhou-msft,
jaredmoo,
jiasli,
mmyyrroonn,
qianwens,
qwordy,
v-Ajnava and
zhoxing-ms
as code owners
|
@haroldrandom excellent work! I'd reconmend support CMv1 in this PR too so that we can keep our dev branch still functionalable. |
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
12 participants
1st step to fix #9432. Which relies on azure-mgmt-network 9.0.0
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.