[Network] Bump to azure-mgmt-network 8.0.0 #12021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump sdk and add test fix all test add history
src/azure-cli/HISTORY.rst
Outdated
Member
There was a problem hiding this comment.
This could be removed now.
mmyyrroonn
commented
Feb 4, 2020
tools/automation/tests/main.py
Outdated
Contributor
Author
There was a problem hiding this comment.
@fengzhou-msft do you know how to debug this script?
Member
There was a problem hiding this comment.
I haven't worked with nose runner, ping @haroldrandom
added 2 commits
February 6, 2020 12:18
mmyyrroonn
force-pushed
the
fix-11988-pe-pls
branch
from
b189e77 to
cd10054
Compare
mmyyrroonn
changed the title
haroldrandom
reviewed
Feb 6, 2020
| c.argument('private_endpoint_connections', nargs='+', help='Space-separated list of private endpoint connections.') | ||
| c.argument('fqdns', nargs='+', help='Space-separated list of FQDNs.') | ||
| c.argument('location', get_location_type(self.cli_ctx), validator=get_default_location_from_resource_group) | ||
| c.argument('enable_proxy_protocol', help='Enable proxy protocol for private link service.', arg_type=get_three_state_flag(), min_api='2019-09-01') |
haroldrandom
approved these changes
Feb 6, 2020
Contributor
haroldrandom
left a comment
haroldrandom
left a comment
There was a problem hiding this comment.
Issue title need change to 8.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11988
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Network] Bump to azure-mgmt-network 8.0.0
[Network] az network private-link-service update/create: support --enable-proxy-protocol
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.