Skip to content

[App Service] On webapp up set httpsonly true #11539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwordy merged 6 commits into from
Dec 31, 2019
Merged

[App Service] On webapp up set httpsonly true #11539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7b6698
https_only = true when using webapp up
ammanifold Dec 9, 2019
5f291b8
update and validate testing
ammanifold Dec 10, 2019
478535f
supress entire file and rerun test
ammanifold Dec 13, 2019
cca015e
update history
ammanifold Dec 20, 2019
e9ef7d7
rerun tests
ammanifold Dec 27, 2019
f142fe3
resetup dev and rerun test
ammanifold Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CredScanSuppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@
"_justification": "[AppConfig] response body contains random value recognized as secret"
},
{
"placeholder": "ibq5S2kTGdSMoYctLg5DSDSyRXRB4n4h4c1otxktmjA=",
"_justification": "access key value in test_webapp_hybridconnectionE2E.yaml"
"file": [
"src\\azure-cli\\azure\\cli\\command_modules\\appservice\\tests\\latest\\recordings\\test_webapp_hybridconnectionE2E.yaml"
],
"_justification": "[AppService] response body contains random value recognized as secret"
},
{
"file": [
Expand Down
1 change: 1 addition & 0 deletions src/azure-cli/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Release History
**AppService**

* Fix issue #7154: Updating documentation for comand <> to use back ticks instead of single quotes
* Fix issue #11287: webapp up: By default make the app created using up 'should be 'SSL enabled'

**ARM**

Expand Down
3 changes: 2 additions & 1 deletion src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ def create_webapp(cmd, resource_group_name, name, plan, runtime=None, startup_fi
if isinstance(plan_info.sku, SkuDescription) and plan_info.sku.name.upper() not in ['F1', 'FREE', 'SHARED', 'D1',
'B1', 'B2', 'B3', 'BASIC']:
site_config.always_on = True
webapp_def = Site(location=location, site_config=site_config, server_farm_id=plan_info.id, tags=tags)
webapp_def = Site(location=location, site_config=site_config, server_farm_id=plan_info.id, tags=tags,
https_only=using_webapp_up)
helper = _StackRuntimeHelper(client, linux=is_linux)

if is_linux:
Expand Down
795 changes: 508 additions & 287 deletions ...ure-cli/azure/cli/command_modules/appservice/tests/latest/recordings/test_webapp_e2e.yaml
View file
Open in desktop

Large diffs are not rendered by default.

359 changes: 180 additions & 179 deletions ...i/command_modules/appservice/tests/latest/recordings/test_webapp_hybridconnectionE2E.yaml
View file
Open in desktop

Large diffs are not rendered by default.

484 changes: 242 additions & 242 deletions ...re/cli/command_modules/appservice/tests/latest/recordings/test_webapp_vnetDelegation.yaml
View file
Open in desktop

Large diffs are not rendered by default.

318 changes: 159 additions & 159 deletions ...cli/azure/cli/command_modules/appservice/tests/latest/recordings/test_webapp_vnetE2E.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ def test_webapp_e2e(self, resource_group):
# show publishing credentials
result = self.cmd('webapp deployment list-publishing-credentials -g {} -n {}'.format(resource_group, webapp_name)).get_output_in_json()
self.assertTrue('scm' in result['scmUri'])
# verify httpsOnly is false
self.cmd('webapp show -g {} -n {}'.format(resource_group, webapp_name), checks=[
JMESPathCheck('httpsOnly', False),
])


class WebappQuickCreateTest(ScenarioTest):
Expand Down