-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[AppConfig]Fix pagination and globalization bugs. #11522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please add @avanigupta as reviewer. Thanks. |
This is part of our python SDK. We have two methods to delete key values. delete_keyvalue(keyvalue) will check etag and fail if mismatch. For delete_keyvalue_by_key_label(key, label) it is a force delete that won't check pre condition. This may not be used in CLI, but we should keep it in internal python sdk. We may consider to use the official python SDK once it is stabilized. In reply to: 564198076 [](ancestors = 564198076) Refers to: src/azure-cli/azure/cli/command_modules/appconfig/_azconfig/azconfig_client.py:153 in f75c1d3. [](commit_id = f75c1d3, deletion_comment = False) |
yes, good catch. I will add it. Same with unlock and delete. In reply to: 564196480 [](ancestors = 564196480) Refers to: src/azure-cli/azure/cli/command_modules/appconfig/_azconfig/azconfig_client.py:319 in f75c1d3. [](commit_id = f75c1d3, deletion_comment = False) |
avanigupta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
Hi @shenmuxiaosen, please update history.rst for your change. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.