-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[AppConfig] Support Import/Export of feature flags #11467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Juliehzl
merged 68 commits into
Azure:dev
from
avanigupta:avanigupta/importexportfeatureflags
Dec 17, 2019
Merged
Changes from 58 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
bf00b70
FeatureManagement CLI Part 1 (#1)
avanigupta 8c78d50
Merge branch 'dev' of https://github.com/avanigupta/azure-cli into dev
avanigupta 61ef19e
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta 9fcb3fd
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta 9889cd3
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta f2024c6
Final changes for feature management CLI (#2)
avanigupta f5c45a5
Fix styling issues
avanigupta d7cc069
String formatting for python 2.7 compatibility
avanigupta 5026d7d
Python 2.7 compatibility for unit tests
avanigupta d8a5c39
fix id attribute for feature flag value
avanigupta c6d2881
Modify list feature default label behavior
avanigupta 30aace3
Check content type for features
avanigupta 7bb402b
CLI team's suggested changes
avanigupta c22469f
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta abc3f20
Update test recordings
avanigupta e41bf4a
Merging with latest code
avanigupta 84a58c7
Changing commands to custom_commands
avanigupta d5e7fcc
Stop reading dest file contents during export
avanigupta 8fb3848
History file update
avanigupta d8bb37e
Merge with latest code
avanigupta 83a8ff2
resolving conflict
avanigupta 2902c69
changed empty label behavior for delete feature
avanigupta 17b8f88
Change warning message
avanigupta f86293d
Removing label from FeatureFlagValue
avanigupta 414e8e0
resolve conflicts
avanigupta f4fce0e
Use shell_safe_json_parse for deserialiization
avanigupta b655295
Merge branch 'dev' into dev
avanigupta b9a262f
Updating export for feature flags
avanigupta ffaa686
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta de14a2f
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta c3b3f75
Get latest code
avanigupta 6441437
Feature export scenario updates
avanigupta 261656f
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta 9d92fa2
Merge with latest code
avanigupta 08dba5d
Import feature flags from json format
avanigupta 738079b
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta 92cd9b6
Merge branch 'dev' into avanigupta/importexportfeatureflags
avanigupta 3f8af31
Adding test
avanigupta 878eb0f
Fix styling
avanigupta 9348709
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta fb71a76
Merge branch 'dev' into avanigupta/importexportfeatureflags
avanigupta 5f550ae
Fix Styling
avanigupta 79a4ccd
UPdate history file
avanigupta 8a2e454
Add sample commands
avanigupta 0850f42
improving help messages
avanigupta 6302636
Split print preview of features and kv
avanigupta c0c50f0
Support alternate json format for ON/OFF features
avanigupta 0fd0415
Adding more tests
avanigupta 6b8b0e2
fix styling
avanigupta ddd84fa
Merge remote-tracking branch 'upstream/dev' into dev
avanigupta 7ff2a02
Merge branch 'dev' into avanigupta/importexportfeatureflags
avanigupta 6f6d400
Use knack logger and enum arg type
avanigupta bccd646
Merge branch 'dev' into avanigupta/importexportfeatureflags
avanigupta 8f752dd
refactoring
avanigupta 62f6b4c
Merge branch 'avanigupta/importexportfeatureflags' of https://github.…
avanigupta bf93ec8
disabling ensure_ascii for json dumps
avanigupta fc56f78
Resolving comments
avanigupta 86fa8bd
Refactoring export command
avanigupta 62033d0
Resolvong CLI side comments
avanigupta 8c0e6fd
Resolving comments
avanigupta 1135de9
Merge branch 'dev' into avanigupta/importexportfeatureflags
avanigupta 934c227
Merge with latest code
avanigupta fbdc589
Update test recordings
avanigupta 939bd41
merging history file
avanigupta ae05b0c
Rename default_value variable
avanigupta 3600d16
Merge branch 'dev' into avanigupta/importexportfeatureflags
avanigupta bbda78f
fix history file
avanigupta f15f2b2
change separator for history file
avanigupta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question here is if the exception raised will throw clear error message.
If not, what about make logger.debug message here be part of exception message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done