Skip to content

Conversation

@haroldrandom
Copy link
Contributor

@haroldrandom haroldrandom commented Nov 30, 2019

Fix #9329

  • Job Dependency Check is duplicated with jobs in AOD, VerifyLinuxRequirements/VerifyWindowsRequirements/VerifyDarwinRequirements , removed,
  • Add unit test job for core, telemetry in Python 2.7, 3.6 and 3.8
  • Add Integration test against profiles in Python 2.7, 3.6 and 3.8
  • Add test for extensions loading in Python 3.6
  • Add Job VerifySphinxDocumentGenerator in Python 3.6
  • Job Nightly Edge Build is useless, replaced by Edge Build in internal ADO, removed
  • Job Automation Docker is useless, removed

for removed job, follow-up is #11510


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@haroldrandom haroldrandom force-pushed the move_travis_to_devops branch 4 times, most recently from ee810da to 70cc9aa Compare November 30, 2019 13:29
@haroldrandom haroldrandom force-pushed the move_travis_to_devops branch 2 times, most recently from b2917e5 to 7a4c096 Compare November 30, 2019 17:36
@haroldrandom haroldrandom removed the request for review from jiasli November 30, 2019 17:39
@haroldrandom haroldrandom self-assigned this Nov 30, 2019
@haroldrandom
Copy link
Contributor Author

Currently, master branch is vulnerable that can be Squash and merge without CI green.

The job in .travis.yml "./scripts/ci/reject_master_prs.sh" has not taken effect.

This would be dangerous.

@haroldrandom haroldrandom requested review from Juliehzl, fengzhou-msft, jiasli, mmyyrroonn and zikalino and removed request for zikalino November 30, 2019 19:15
@haroldrandom haroldrandom added the CI CI label Dec 1, 2019
@haroldrandom haroldrandom force-pushed the move_travis_to_devops branch 3 times, most recently from ee462e5 to 06588f5 Compare December 2, 2019 02:49
@haroldrandom haroldrandom force-pushed the move_travis_to_devops branch from 06588f5 to b25c746 Compare December 2, 2019 02:52
@yungezz
Copy link
Member

yungezz commented Dec 2, 2019

Currently, master branch is vulnerable that can be Squash and merge without CI green.

The job in .travis.yml "./scripts/ci/reject_master_prs.sh" has not taken effect.

This would be dangerous.

This could be configured in repo settting. what's the impact of mark CI as required for PR today? If impact is clear, I can do it.

@haroldrandom
Copy link
Contributor Author

Currently, master branch is vulnerable that can be Squash and merge without CI green.
The job in .travis.yml "./scripts/ci/reject_master_prs.sh" has not taken effect.
This would be dangerous.

This could be configured in repo settting. what's the impact of mark CI as required for PR today? If impact is clear, I can do it.

@jiasli suggest that master branch is useless for now, no need to enable this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks what test_profile_integration.sh does is verifying all the modules can be loaded correctly according to here. Integration Tests against different profiles are done in job RunAutomationxxxx, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, need to be more accurate. What name would you like?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VerifyCommandsLoadingAgainstProfiles ?

@haroldrandom haroldrandom force-pushed the move_travis_to_devops branch from 538c358 to 409dd2f Compare December 6, 2019 09:27
@haroldrandom
Copy link
Contributor Author

@haroldrandom haroldrandom force-pushed the move_travis_to_devops branch from 409dd2f to a64544f Compare December 9, 2019 06:29
@haroldrandom haroldrandom force-pushed the move_travis_to_devops branch from a64544f to b25c746 Compare December 9, 2019 06:44
@haroldrandom haroldrandom changed the title [CI] Totally replace Travis with Azure DevOps [CI] Move jobs in Travis to Azure DevOps Dec 9, 2019
@haroldrandom haroldrandom merged commit 3b75d3c into Azure:dev Dec 9, 2019
@haroldrandom haroldrandom deleted the move_travis_to_devops branch December 9, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to shift off of Travis CI by Jun 28, 2019

5 participants