-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[CI] Move jobs in Travis to Azure DevOps #11442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee810da to
70cc9aa
Compare
b2917e5 to
7a4c096
Compare
7a4c096 to
dc92b0b
Compare
|
Currently, master branch is vulnerable that can be Squash and merge without CI green. The job in This would be dangerous. |
ee462e5 to
06588f5
Compare
06588f5 to
b25c746
Compare
This could be configured in repo settting. what's the impact of mark CI as required for PR today? If impact is clear, I can do it. |
56f61cd to
b25c746
Compare
@jiasli suggest that master branch is useless for now, no need to enable this. |
azure-pipelines.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks what test_profile_integration.sh does is verifying all the modules can be loaded correctly according to here. Integration Tests against different profiles are done in job RunAutomationxxxx, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, need to be more accurate. What name would you like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VerifyCommandsLoadingAgainstProfiles ?
538c358 to
409dd2f
Compare
|
@yungezz @yonzhan @jiasli @zikalino Could one of our azure-cli repo admin disable Travis for this? |
409dd2f to
a64544f
Compare
a64544f to
b25c746
Compare
Fix #9329
for removed job, follow-up is #11510
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.