-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Core] Expose example_provider hook to include AI examples #10987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
616eadf
Update Cloud Shell to use the az find generated examples
mirdaki-ms 43c6c48
Add unit tests to the find module and mock network connection
mirdaki-ms 49e455c
Add flag to use default examples if generated ones fail
mirdaki-ms 1d44b56
Fix the circular dependency caused by the help find integration
mirdaki-ms 2f2ce59
Merge branch 'dev' into cloudShellGeneratedExamples
mirdaki-ms 214b04c
Update styling to pass CI/CD
mirdaki-ms 47296af
Another style update
mirdaki-ms 84dadb4
Improve dependency injection approach and improve function naming
mirdaki-ms 38b7f38
Specify "az" lookup to force the examples to have the exact command
mirdaki-ms e9535ad
Remove find connection to help examples
mirdaki-ms 7cf1f4d
Remove extra new line
mirdaki-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
example_providerrely onhelp_file.examples? In other words, isexample_providerappending theaz findexamples to the manually-written examples by itself? If not, I would prefer only passinghelp_file.commandto reduce coupling.If so, the code is good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ai-examplesextension needs both the command that's being looked up and the examples that command has so it can prevent any duplicate examples from being added by the Aladdin service.help_filehas both of those values, so I'd like to keep the current usage of it.It also gives the extension the possibility of changing the order of all the examples. For instance, we could do something like organize them by usage (to be clear: it's not something we're planning right now, but could be useful in the future).