Repository navigation
Rewrite az in python - #10516
Merged
Merged
Rewrite az in python#10516
Conversation
Use python instead of bash, so that we get benefits from of using "#!/usr/bin/env python" - distutils will replace it with an absolute path to the specific python interpreter being used (helps with tools like pipx) - if running inside a virtualenv as is, it will run the python interpreter for that virtualenv (as found first in PATH) There doesn't seem to be a measurable startup delay impact as has been reported with using entry_points/console_script.
|
|
Myron (mmyyrroonn)
requested review from
Zihong (1openwindow),
Feng Zhou (fengzhou-msft) and
Zim Kalinowski (zikalino)
and removed request for
Zihong (1openwindow)
September 16, 2019 02:13
Feng Zhou (fengzhou-msft)
left a comment
Feng Zhou (fengzhou-msft)
left a comment
Member
There was a problem hiding this comment.
code looks good to me, will do tests with python2 and python3
Contributor
Author
|
I've tested it with
|
Feng Zhou (fengzhou-msft)
previously approved these changes
Sep 23, 2019
Contributor
Author
|
Feng Zhou (@fengzhou-msft) - Didn't mean to dismiss any reviews, but just keep this branch without merge conflicts. Maybe it is better I don't resolve conflicts going forward -- it is just about |
Yong Zhang (yonzhan)
requested review from
Harold Ran (haroldrandom) and
Myron (mmyyrroonn)
October 14, 2019 01:09
Collaborator
|
Feng Zhou (@fengzhou-msft) please help deal with this PR. |
Member
|
Yong Zhang (@yonzhan) I have tested the code, it works as stated and solved several issues. This change impacts the entry point for running all commands when installed with pip. We need Zim Kalinowski (@zikalino) to review and see if there's any drawbacks. |
Collaborator
|
Zim Kalinowski (@zikalino) please review this PR. |
2 tasks done
Feng Zhou (fengzhou-msft)
approved these changes
Nov 4, 2019
Member
|
/azp run |
|
Pull request contains merge conflicts. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use python instead of bash, so that we get benefits from using
#!/usr/bin/env python:distutilswill replace it with an absolute path to the specific python interpreter being usedpip install(Support python3 executable when running az #1043)pipx(azure-cli: No module named 'azure' pypa/pipx#162)virtualenvas is, it will run the python interpreter for thatvirtualenv(No module named azure in pyvenv #3989)There doesn't seem to be a measurable startup delay impact as has been reported with using
entry_points/console_script(#7469).This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.