Update dependency to use Python package azure-mgmt-resource_3.1.0 #10123

hjhhh3000vitae · 2019-08-02T00:13:40Z

Using azure-mgmt-resource_3.1.0

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.

mmyyrroonn · 2019-08-07T03:31:44Z

@hjhhh3000vitae Hello. You should run azdev test <module_name> to see the failure test. Then run azdev test <module_name> --live --lf to record the test again in this PR to pass the CI.

hjhhh3000vitae · 2019-08-13T22:09:04Z

A code change to fix incompatibility to new api version is made in this PR according to Azure/azure-rest-api-specs#6393

hjhhh3000vitae · 2019-08-13T23:56:01Z

@hjhhh3000vitae Hello. You should run azdev test <module_name> to see the failure test. Then run azdev test <module_name> --live --lf to record the test again in this PR to pass the CI.

Hello @myronfanqiu ! Thanks for the instruction. I tried azdev test resource and it told me all 84 tests succeeded, but for azdev test resource --live --lf, it said 38 out of 84 tests failed and looks like it deleted recordings of these failed tests. Do you know if this behavior is expected?

mmyyrroonn · 2019-08-14T01:38:24Z

@hjhhh3000vitae Hello. You should run azdev test <module_name> to see the failure test. Then run azdev test <module_name> --live --lf to record the test again in this PR to pass the CI.

Hello @myronfanqiu ! Thanks for the instruction. I tried azdev test resource and it told me all 84 tests succeeded, but for azdev test resource --live --lf, it said 38 out of 84 tests failed and looks like it deleted recordings of these failed tests. Do you know if this behavior is expected?

It's weird if you passed all the tests by running azdev test resource since it failed in the CI system. If you run azdev test resource --live --lf, all the recording files will be deleted and re-recorded. Basically, you should pass the test by running azdev test resource --live --lf since the recording files are just a simulated cloud.

hjhhh3000vitae · 2019-08-15T00:06:37Z

@hjhhh3000vitae Hello. You should run azdev test <module_name> to see the failure test. Then run azdev test <module_name> --live --lf to record the test again in this PR to pass the CI.

Hello @myronfanqiu ! Thanks for the instruction. I tried azdev test resource and it told me all 84 tests succeeded, but for azdev test resource --live --lf, it said 38 out of 84 tests failed and looks like it deleted recordings of these failed tests. Do you know if this behavior is expected?

It's weird if you passed all the tests by running azdev test resource since it failed in the CI system. If you run azdev test resource --live --lf, all the recording files will be deleted and re-recorded. Basically, you should pass the test by running azdev test resource --live --lf since the recording files are just a simulated cloud.

@myronfanqiu Thanks. I checked the tests locally and fixed some of them.

For now, on the local side, I tried running tests using azdev test resource --live against dev branch and still some of the tests are failing so I am assuming it is configuration issue?

On the online side, however, I checked the log of the tests. It looks like none of the failing/error tests is from the resource module, which I am working on in this PR. Most of them are from AppService. Is that anyway I can kick-off a online testing pipeline against 'dev' branch to do a comparison here? Thank you.

I am not sure why the online checks are still failing now as looking from the log, all the failing tests are not from resource module, which I am working on in this branch but from AppService mostly.

mmyyrroonn · 2019-08-15T01:49:59Z

@hjhhh3000vitae Hello. You should run azdev test <module_name> to see the failure test. Then run azdev test <module_name> --live --lf to record the test again in this PR to pass the CI.

Hello @myronfanqiu ! Thanks for the instruction. I tried azdev test resource and it told me all 84 tests succeeded, but for azdev test resource --live --lf, it said 38 out of 84 tests failed and looks like it deleted recordings of these failed tests. Do you know if this behavior is expected?

It's weird if you passed all the tests by running azdev test resource since it failed in the CI system. If you run azdev test resource --live --lf, all the recording files will be deleted and re-recorded. Basically, you should pass the test by running azdev test resource --live --lf since the recording files are just a simulated cloud.

@myronfanqiu Thanks. I checked the tests locally and fixed some of them.

For now, on the local side, I tried running tests using azdev test resource --live against dev branch and still some of the tests are failing so I am assuming it is configuration issue?

On the online side, however, I checked the log of the tests. It looks like none of the failing/error tests is from the resource module, which I am working on in this PR. Most of them are from AppService. Is that anyway I can kick-off a online testing pipeline against 'dev' branch to do a comparison here? Thank you.

I am not sure why the online checks are still failing now as looking from the log, all the failing tests are not from resource module, which I am working on in this branch but from AppService mostly.

Hello, you should run azdev test resource against your development branch and push these recording yml together within this PR.

I tested the appservice locally and all tests passed. Could you please run azdev test appservice to see the results?

If you can passed the test locally, we should check our CI system. If you cannot pass them locally, we need to figure out what happened to the appservice. In either case, we need your help.

mmyyrroonn · 2019-08-19T01:40:15Z

@hjhhh3000vitae Hello. Did these command modules use the resource SDK?

hjhhh3000vitae · 2019-08-19T03:18:11Z

@hjhhh3000vitae Hello. Did these command modules use the resource SDK?

I can confirm they are using ResourceManagementClient from resource SDK.

Juliehzl · 2019-08-21T16:54:49Z

...zure/cli/command_modules/appservice/tests/latest/recordings/test_download_linux_web_log.yaml

Because the !!python/unicode in response body, response body cannot be parsed correctly. Why do you have such string in your recording file? When I delete !!python/unicode manually, it works. In addition, please have a look at other !!python/unicode in the following part.

The following tests cannot pass on live mode: test_network_app_gateway_waf_policy test_hdinsight_application test_hdinsight_monitor test_batchai_usages test_batchai_job_level_mounting_scenario test_batchai_config_less_cluster_with_file_systems test_batchai_cluster_with_setup_command test_batchai_cluster_with_file_systems test_batchai_auto_scale_scenario test_batchai_cluster_with_auto_storage test_network_lb_zone test_batchai_manual_scale_scenario

hjhhh3000vitae · 2019-08-31T06:45:15Z

@myronfanqiu @Juliehzl @yugangw-msft Tests now all passed. Could you please review this PR.

hjhhh3000vitae marked this pull request as ready for review August 2, 2019 00:19

hjhhh3000vitae requested a review from yugangw-msft August 2, 2019 18:22

Juliehzl reviewed Aug 21, 2019

View reviewed changes

He Huang added 19 commits August 21, 2019 11:51

Update dependency

8b0171b

Update history

d91879a

Update setup.py

6b25481

Fix version incompatible for policy

1661234

Fix test

374d42c

Update test recordings in AppService

38e2131

Update test recordings in CosmosDB

4ea6b70

Update test recordings in iotcentral

57969ad

Update test recordings in search

8cab2fd

Update test recordings in sql

6864e88

Update test recordings in iot

dd132eb

Update test recordings in monitor

4de5d12

Update test recordings in appservice

d923a40

Update test recording in AppService

c9523b4

Update test recording in AppService

92a8a43

Update recording of test_download_linux_web_log

4a6a6d8

Manually fix test

a1f092c

Update tests after conflict

8950d8b

Fix HISTORY

4936845

He Huang added 12 commits August 21, 2019 18:07

Update test recordings

52f7381

Update api version

77d596d

Merge remote-tracking branch 'azure/dev' into resource20190510

a6e2732

Update resource module test recording

1be86b7

Skip test_download_linux_web_log

13aa10e

Merge remote-tracking branch 'azure/dev' into resource20190510

19d79d7

Update api version in test recording

62d2cf2

Update hdinsight test recordings

a3fd592

Update test recordings in batchai and network

81a9fb0

Update management group test recording

14063c7

Update test_acr_image_import recording

077bbe2

mmyyrroonn assigned acs-bot and Juliehzl and unassigned acs-bot Sep 2, 2019

yugangw-msft approved these changes Sep 2, 2019

View reviewed changes

yugangw-msft merged commit 8aa2eb5 into Azure:dev Sep 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update dependency to use Python package azure-mgmt-resource_3.1.0 #10123

Update dependency to use Python package azure-mgmt-resource_3.1.0 #10123

Uh oh!

hjhhh3000vitae commented Aug 2, 2019 •

edited

Loading

Uh oh!

mmyyrroonn commented Aug 7, 2019

Uh oh!

hjhhh3000vitae commented Aug 13, 2019

Uh oh!

hjhhh3000vitae commented Aug 13, 2019

Uh oh!

mmyyrroonn commented Aug 14, 2019

Uh oh!

hjhhh3000vitae commented Aug 15, 2019

Uh oh!

mmyyrroonn commented Aug 15, 2019 •

edited

Loading

Uh oh!

mmyyrroonn commented Aug 19, 2019

Uh oh!

hjhhh3000vitae commented Aug 19, 2019

Uh oh!

Juliehzl Aug 21, 2019

Uh oh!

hjhhh3000vitae commented Aug 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Update dependency to use Python package azure-mgmt-resource_3.1.0 #10123

Update dependency to use Python package azure-mgmt-resource_3.1.0 #10123

Uh oh!

Conversation

hjhhh3000vitae commented Aug 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Using azure-mgmt-resource_3.1.0

Uh oh!

mmyyrroonn commented Aug 7, 2019

Uh oh!

hjhhh3000vitae commented Aug 13, 2019

Uh oh!

hjhhh3000vitae commented Aug 13, 2019

Uh oh!

mmyyrroonn commented Aug 14, 2019

Uh oh!

hjhhh3000vitae commented Aug 15, 2019

Uh oh!

mmyyrroonn commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmyyrroonn commented Aug 19, 2019

Uh oh!

hjhhh3000vitae commented Aug 19, 2019

Uh oh!

Juliehzl Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

hjhhh3000vitae commented Aug 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hjhhh3000vitae commented Aug 2, 2019 •

edited

Loading

mmyyrroonn commented Aug 15, 2019 •

edited

Loading