Skip to content

fix: remove confcom index#9484

Merged
necusjz merged 1 commit intoAzure:mainfrom
necusjz:rever-confcom-index
Dec 17, 2025
Merged

fix: remove confcom index#9484
necusjz merged 1 commit intoAzure:mainfrom
necusjz:rever-confcom-index

Conversation

@necusjz
Copy link
Member

@necusjz necusjz commented Dec 17, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

continuous removal of #9483.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@necusjz necusjz self-assigned this Dec 17, 2025
Copilot AI review requested due to automatic review settings December 17, 2025 09:00
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 17, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @necusjz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the confcom version 1.5.0 entry from the extension index as a continuation of cleanup work from PR #9483. The removal is syntactically correct and maintains valid JSON structure.

However, there is a critical inconsistency: while version 1.5.0 is being removed from the index, the extension source code in src/confcom/ still declares version 1.5.0 in both setup.py and HISTORY.rst, creating a mismatch between the published index and the extension source.

"version": "1.5.0"
},
"sha256Digest": "1ca9b8f1e6d2f526666fe86ca86f7ed8a0b4455ae10df311def0471d3d8467b6"
}
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the confcom 1.5.0 entry from index.json, but the extension source code in src/confcom/ still declares version 1.5.0 in setup.py (line 22) and includes 1.5.0 release notes in HISTORY.rst (lines 6-10). This creates an inconsistency where the extension source indicates version 1.5.0 exists, but it won't be available in the published index.

If version 1.5.0 should be removed entirely, the VERSION in src/confcom/setup.py should be reverted to 1.4.5, and the 1.5.0 entry in src/confcom/HISTORY.rst should be removed or marked as unpublished. Alternatively, if 1.5.0 is the intended current version, this index.json removal should be reconsidered.

Copilot uses AI. Check for mistakes.
@necusjz necusjz merged commit 733c84b into Azure:main Dec 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants