Skip to content

fix: acns-datapath-acceleration-mode None should set the API field correctly #9255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julie Zhu (yanzhudd) merged 4 commits into from
Sep 30, 2025
Merged

fix: acns-datapath-acceleration-mode None should set the API field correctly #9255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2640aa0
Fix datapath acceleration mode
santhoshmprabhu Sep 29, 2025
c1fe0b0
fix: address comments
santhoshmprabhu Sep 30, 2025
2b5804b
fix: fix failing test
santhoshmprabhu Sep 30, 2025
21775d3
test: update recording
santhoshmprabhu Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Pending
* Fix `--localdns-config` parameter to handle null values in JSON configuration files gracefully, preventing crashes when DNS override sections are null.
* Add jwtauthenticator commands `az aks jwtauthenticator add/update/show/list/delete` to manage JWT authenticators for a managed cluster.

18.0.0b41
+++++++
* Fix an issue in disabling ACNS performance (--acns-datapath-acceleration-mode None).
Comment thread
santhoshmprabhu marked this conversation as resolved.

18.0.0b40
+++++++
* Add option `Windows2025` to `--os-sku` for `az aks nodepool add`.
Expand Down
4 changes: 2 additions & 2 deletions src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3180,7 +3180,7 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
if acns.security.transit_encryption is None:
acns.security.transit_encryption = self.models.AdvancedNetworkingSecurityTransitEncryption()
acns.security.transit_encryption.type = acns_transit_encryption_type
if acns_datapath_acceleration_mode == CONST_ACNS_DATAPATH_ACCELERATION_MODE_BPFVETH:
if acns_datapath_acceleration_mode is not None:
if acns.performance is None:
acns.performance = self.models.AdvancedNetworkingPerformance()
acns.performance.acceleration_mode = acns_datapath_acceleration_mode
Expand Down Expand Up @@ -4434,7 +4434,7 @@ def update_acns_in_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
if acns.security.transit_encryption is None:
acns.security.transit_encryption = self.models.AdvancedNetworkingSecurityTransitEncryption()
acns.security.transit_encryption.type = acns_transit_encryption_type
if acns_datapath_acceleration_mode == CONST_ACNS_DATAPATH_ACCELERATION_MODE_BPFVETH:
if acns_datapath_acceleration_mode is not None:
if acns.performance is None:
acns.performance = self.models.AdvancedNetworkingPerformance()
acns.performance.acceleration_mode = acns_datapath_acceleration_mode
Expand Down
15 changes: 15 additions & 0 deletions src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14682,6 +14682,21 @@ def test_aks_create_with_acns_performance(
],
)

# Update transit encryption type to WireGuard and advanced network policies to L7
Comment thread
santhoshmprabhu marked this conversation as resolved.
Outdated
update_cmd = (
"aks update --resource-group={resource_group} --name={name} "
"--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AdvancedNetworkingPerformancePreview "
"--enable-acns --acns-datapath-acceleration-mode None"
)

self.cmd(
update_cmd,
checks=[
self.check("provisioningState", "Succeeded"),
self.check("networkProfile.advancedNetworking.performance.accelerationMode", "BpfVeth"),
],
)

# delete
self.cmd(
"aks delete -g {resource_group} -n {name} --yes --no-wait",
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import find_packages, setup

VERSION = "18.0.0b40"
VERSION = "18.0.0b41"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand Down
Loading