Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Jun 30, 2025

Update the comment for acquiring certificate to reflect below changes:

  1. {Auth} Bring back get_msal_token for acquiring VM SSH certificate azure-cli#31082 brought back get_msal_token as the official interface for getting certificate.
  2. {Auth} Drop data keyword argument from get_token azure-cli#31723 dropped data from get_token

These changes doesn't require a new version of ssh to be released as get_msal_token will be called automatically.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 30, 2025 07:55
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 30, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 30, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@azure-client-tools-bot-prd
Copy link

Hi @jiasli,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates inline comments in the SSH extension’s certificate acquisition logic to reference recent Azure CLI changes around authentication methods.

  • Clarifies that get_msal_token was reintroduced in Azure CLI 2.76 and links the corresponding PR
  • Notes that the data parameter was removed from get_token in the same release and updates the deprecation TODO
Comments suppressed due to low confidence (2)

src/ssh/azext_ssh/custom.py:225

  • [nitpick] For consistency and clarity, wrap get_msal_token in backticks and refine the wording, e.g.: “Azure CLI 2.76 reintroduced get_msal_token as the official interface for acquiring certificates.”
    # Azure CLI 2.76 brought back get_msal_token as the official interface for getting certificate:

src/ssh/azext_ssh/custom.py:231

  • [nitpick] Consider verifying the version number and rephrasing for precision, for example: “Azure CLI 2.76 removed support for passing data to get_token” to match the phrasing above and avoid confusion.
        # Azure CLI 2.76 dropped `data` from get_token: https://github.com/Azure/azure-cli/pull/31723

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @jiasli

Release Suggestions

Module: ssh

  • Please log updates into to src/ssh/HISTORY.rst
  • Update VERSION to 2.1.0 in src/ssh/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants