-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{SSH} Update the comment for acquiring certificate #8911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @jiasli, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates inline comments in the SSH extension’s certificate acquisition logic to reference recent Azure CLI changes around authentication methods.
- Clarifies that
get_msal_tokenwas reintroduced in Azure CLI 2.76 and links the corresponding PR - Notes that the
dataparameter was removed fromget_tokenin the same release and updates the deprecation TODO
Comments suppressed due to low confidence (2)
src/ssh/azext_ssh/custom.py:225
- [nitpick] For consistency and clarity, wrap
get_msal_tokenin backticks and refine the wording, e.g.: “Azure CLI 2.76 reintroducedget_msal_tokenas the official interface for acquiring certificates.”
# Azure CLI 2.76 brought back get_msal_token as the official interface for getting certificate:
src/ssh/azext_ssh/custom.py:231
- [nitpick] Consider verifying the version number and rephrasing for precision, for example: “Azure CLI 2.76 removed support for passing
datatoget_token” to match the phrasing above and avoid confusion.
# Azure CLI 2.76 dropped `data` from get_token: https://github.com/Azure/azure-cli/pull/31723
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @jiasli Release SuggestionsModule: ssh
Notes
|
Update the comment for acquiring certificate to reflect below changes:
get_msal_tokenfor acquiring VM SSH certificate azure-cli#31082 brought backget_msal_tokenas the official interface for getting certificate.datakeyword argument fromget_tokenazure-cli#31723 droppeddatafromget_tokenThese changes doesn't require a new version of
sshto be released asget_msal_tokenwill be called automatically.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.