{Zones} Release bugfix to improve command loading#8766
Conversation
|
Hi @nielsams, |
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces minor bugfixes and code style updates across resource type validators in the Zones extension, and bumps the extension’s beta version.
- Add
# pylint: disable=too-few-public-methodsto each validator module - Simplify conditional return statements by removing redundant
elseblocks - Fix a missing
returnin the Microsoft.DocumentDB validator and add a return for the BotService warning path - Update
HISTORY.rstto1.0.0b3
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/zones/azext_zones/resource_type_validators/microsoft_eventhub.py | Wrap long comment and simplify return |
| src/zones/azext_zones/resource_type_validators/microsoft_eventgrid.py | Add pylint disable |
| src/zones/azext_zones/resource_type_validators/microsoft_documentdb.py | Correct missing return in second branch |
| src/zones/azext_zones/resource_type_validators/microsoft_dbforpostgresql.py | Simplify if/else to early return |
| src/zones/azext_zones/resource_type_validators/microsoft_dbformysql.py | Simplify if/else to early return |
| src/zones/azext_zones/resource_type_validators/microsoft_dashboard.py | Simplify if/else to early return |
| src/zones/azext_zones/resource_type_validators/microsoft_containerservice.py | Convert ternary return to if/return |
| src/zones/azext_zones/resource_type_validators/microsoft_containerregistry.py | Simplify if/else to early return |
| src/zones/azext_zones/resource_type_validators/microsoft_containerinstance.py | Add pylint disable |
| src/zones/azext_zones/resource_type_validators/microsoft_compute.py | Add pylint disables and simplify if/else |
| src/zones/azext_zones/resource_type_validators/microsoft_chaos.py | Add pylint disable |
| src/zones/azext_zones/resource_type_validators/microsoft_cdn.py | Add pylint disable |
| src/zones/azext_zones/resource_type_validators/microsoft_cache.py | Simplify if/else to early return |
| src/zones/azext_zones/resource_type_validators/microsoft_botservice.py | Fix missing return on warning path |
| src/zones/azext_zones/resource_type_validators/microsoft_automation.py | Add pylint disable |
| src/zones/azext_zones/resource_type_validators/microsoft_authorization.py | Add pylint disable |
| src/zones/azext_zones/resource_type_validators/microsoft_app.py | Simplify if/else to early return |
| src/zones/azext_zones/resource_type_validators/microsoft_apimanagement.py | Simplify if/else to early return |
| src/zones/azext_zones/resource_type_validators/init.py | Add module header and docstring |
| src/zones/HISTORY.rst | Bump to version 1.0.0b3 and add release notes |
Comments suppressed due to low confidence (2)
src/zones/azext_zones/resource_type_validators/microsoft_eventhub.py:28
- Add a unit test to verify that the Event Hubs validator always returns
ZoneRedundancyValidationResult.Alwaysfor regions with availability zone support.
return ZoneRedundancyValidationResult.Always
src/zones/azext_zones/resource_type_validators/microsoft_botservice.py:36
- Introduce a unit test covering the new warning path that returns
ZoneRedundancyValidationResult.Unknownfor regional Bot Service in West Europe.
return ZoneRedundancyValidationResult.Unknown
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ zones-1.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124753948&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.