Skip to content

Conversation

@warren-jones
Copy link
Contributor

@warren-jones warren-jones commented Jan 30, 2025

Added storage account properties to workspace-creation ARM template:

  • "allowBlobPublicAccess": false
  • "minimumTlsVersion": "TLS1_2"

Updated the storage account API version to "2023-05-01".


Related command

az quantum workspace create


  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 30, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @warren-jones,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 30, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 30, 2025
@warren-jones warren-jones changed the title [Draft - Do not merge] [Quantum] Disable blob public access and set minimum TLS version [Draft - Do not merge] [Quantum] Disable blob public access and set minimum TLS version (31013) Jan 30, 2025
@github-actions
Copy link

Hi @warren-jones

Release Suggestions

Module: quantum

  • Please log updates into to src/quantum/HISTORY.rst
  • Update VERSION to 1.0.0b5 in src/quantum/setup.py

Notes

@yonzhan yonzhan requested a review from jsntcy January 31, 2025 00:24
@warren-jones warren-jones marked this pull request as ready for review January 31, 2025 02:38
@warren-jones warren-jones changed the title [Draft - Do not merge] [Quantum] Disable blob public access and set minimum TLS version (31013) [Quantum] Disable blob public access and set minimum TLS version (31013) Jan 31, 2025
@necusjz
Copy link
Member

necusjz commented Feb 3, 2025

Hi @warren-jones

Release Suggestions

Module: quantum

  • Please log updates into to src/quantum/HISTORY.rst
  • Update VERSION to 1.0.0b5 in src/quantum/setup.py

Notes

do we wanna release a new version? if so, pls modify these two files.

@warren-jones
Copy link
Contributor Author

Hi @necusjz,
I am waiting for my team to finish reviewing of one more PR that is still a draft: CLI PR 8242. I will update src/quantum/HISTORY.rst and src/quantum/setup.py in a Release PR after that draft PR ready for review and merge by the Azure CLI team. Thanks!

@necusjz necusjz merged commit 3f2b5ad into Azure:main Feb 3, 2025
22 checks passed
Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
…13) (Azure#8450)

* Added properties to ARM template

* Update storage account API version

* Deleted a stray comma

* Restored the version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Quantum az quantum

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants