[Containerapp]: az containerapp arc: Enable setup custom core dns for Aks AzureCore on Arc.#8428
Merged
yanzhudd merged 5 commits intoAzure:mainfrom Jan 22, 2025
Merged
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp arc | sub group containerapp arc added |
|
Hi @LaylaLiu-gmail, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: containerapp
Notes
|
Greedygre
reviewed
Jan 20, 2025
Contributor
|
Recommend title: |
LaylaLiu-gmail
changed the title
Greedygre
reviewed
Jan 21, 2025
Greedygre
reviewed
Jan 21, 2025
Greedygre
reviewed
Jan 21, 2025
Greedygre
reviewed
Jan 21, 2025
src/containerapp/azext_containerapp/tests/latest/test_containerapp_arc_commands.py
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Greedygre
reviewed
Jan 21, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Greedygre
reviewed
Jan 22, 2025
Greedygre
reviewed
Jan 22, 2025
Greedygre
reviewed
Jan 22, 2025
src/containerapp/azext_containerapp/tests/latest/test_containerapp_arc_commands.py
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Greedygre
reviewed
Jan 22, 2025
Greedygre
approved these changes
Jan 22, 2025
yanzhudd
reviewed
Jan 22, 2025
yanzhudd
approved these changes
Jan 22, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Jenniferyingni
pushed a commit
to Jenniferyingni/azure-cli-extensions
that referenced
this pull request
Feb 9, 2025
… Aks AzureCore on Arc. (Azure#8428)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add a new command 'az containerapp arc setup-core-dns' to setup the core dns for Aks AzureCore on Arc.
Related command
az containerapp arc setup-core-dns
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.