Skip to content

Durabletask shorthand fixes and readme fixes#8414

Merged
kairu-ms merged 3 commits intoAzure:mainfrom
RyanLettieri:durabletask-shorthand-fixes
Jan 26, 2025
Merged

Durabletask shorthand fixes and readme fixes#8414
kairu-ms merged 3 commits intoAzure:mainfrom
RyanLettieri:durabletask-shorthand-fixes

Conversation

@RyanLettieri
Copy link
Contributor

@RyanLettieri RyanLettieri commented Jan 13, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Associated aaz PR: Azure/aaz#672

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 13, 2025

❌Azure CLI Extensions Breaking Change Test
❌durabletask
rule cmd_name rule_message suggest_message
1006 - ParaAdd durabletask scheduler create cmd durabletask scheduler create added parameter name please remove parameter name for cmd durabletask scheduler create
1007 - ParaRemove durabletask scheduler create cmd durabletask scheduler create removed parameter scheduler_name please add back parameter scheduler_name for cmd durabletask scheduler create
1006 - ParaAdd durabletask scheduler delete cmd durabletask scheduler delete added parameter name please remove parameter name for cmd durabletask scheduler delete
1007 - ParaRemove durabletask scheduler delete cmd durabletask scheduler delete removed parameter scheduler_name please add back parameter scheduler_name for cmd durabletask scheduler delete
1006 - ParaAdd durabletask scheduler show cmd durabletask scheduler show added parameter name please remove parameter name for cmd durabletask scheduler show
1007 - ParaRemove durabletask scheduler show cmd durabletask scheduler show removed parameter scheduler_name please add back parameter scheduler_name for cmd durabletask scheduler show
1006 - ParaAdd durabletask scheduler update cmd durabletask scheduler update added parameter name please remove parameter name for cmd durabletask scheduler update
1007 - ParaRemove durabletask scheduler update cmd durabletask scheduler update removed parameter scheduler_name please add back parameter scheduler_name for cmd durabletask scheduler update
1006 - ParaAdd durabletask scheduler wait cmd durabletask scheduler wait added parameter name please remove parameter name for cmd durabletask scheduler wait
1007 - ParaRemove durabletask scheduler wait cmd durabletask scheduler wait removed parameter scheduler_name please add back parameter scheduler_name for cmd durabletask scheduler wait
1006 - ParaAdd durabletask taskhub create cmd durabletask taskhub create added parameter name please remove parameter name for cmd durabletask taskhub create
1007 - ParaRemove durabletask taskhub create cmd durabletask taskhub create removed parameter task_hub_name please add back parameter task_hub_name for cmd durabletask taskhub create
1006 - ParaAdd durabletask taskhub delete cmd durabletask taskhub delete added parameter name please remove parameter name for cmd durabletask taskhub delete
1007 - ParaRemove durabletask taskhub delete cmd durabletask taskhub delete removed parameter task_hub_name please add back parameter task_hub_name for cmd durabletask taskhub delete
1006 - ParaAdd durabletask taskhub show cmd durabletask taskhub show added parameter name please remove parameter name for cmd durabletask taskhub show
1007 - ParaRemove durabletask taskhub show cmd durabletask taskhub show removed parameter task_hub_name please add back parameter task_hub_name for cmd durabletask taskhub show
1006 - ParaAdd durabletask taskhub update cmd durabletask taskhub update added parameter name please remove parameter name for cmd durabletask taskhub update
1007 - ParaRemove durabletask taskhub update cmd durabletask taskhub update removed parameter task_hub_name please add back parameter task_hub_name for cmd durabletask taskhub update
1006 - ParaAdd durabletask taskhub wait cmd durabletask taskhub wait added parameter name please remove parameter name for cmd durabletask taskhub wait
1007 - ParaRemove durabletask taskhub wait cmd durabletask taskhub wait removed parameter task_hub_name please add back parameter task_hub_name for cmd durabletask taskhub wait
⚠️ 1010 - ParaPropUpdate durabletask taskhub create cmd durabletask taskhub create update parameter scheduler_name: updated property options from ['--scheduler-name'] to ['--scheduler-name', '-s']
⚠️ 1010 - ParaPropUpdate durabletask taskhub delete cmd durabletask taskhub delete update parameter scheduler_name: updated property options from ['--scheduler-name'] to ['--scheduler-name', '-s']
⚠️ 1010 - ParaPropUpdate durabletask taskhub list cmd durabletask taskhub list update parameter scheduler_name: updated property options from ['--scheduler-name'] to ['--scheduler-name', '-s']
⚠️ 1010 - ParaPropUpdate durabletask taskhub show cmd durabletask taskhub show update parameter scheduler_name: updated property options from ['--scheduler-name'] to ['--scheduler-name', '-s']
⚠️ 1010 - ParaPropUpdate durabletask taskhub update cmd durabletask taskhub update update parameter scheduler_name: updated property options from ['--scheduler-name'] to ['--scheduler-name', '-s']
⚠️ 1010 - ParaPropUpdate durabletask taskhub wait cmd durabletask taskhub wait update parameter scheduler_name: updated property options from ['--scheduler-name'] to ['--scheduler-name', '-s']

@azure-client-tools-bot-prd
Copy link

Hi @RyanLettieri,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @RyanLettieri,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 13, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @RyanLettieri

Release Suggestions

Module: durabletask

  • Please log updates into to src/durabletask/HISTORY.rst
  • Update VERSION to 1.0.0b3 in src/durabletask/setup.py

Notes

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another inconsistency that I noticed, which is we treat "taskhub" the command as one word, but the "task-hub-name" parameter treats it as two works. To avoid confusion, I suggest we change all usages of --task-hub-name to --taskhub-name or, perhaps even better, --taskhub.

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
@RyanLettieri RyanLettieri force-pushed the durabletask-shorthand-fixes branch from 368b2a6 to 899c8f3 Compare January 21, 2025 18:38
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit 24b3e35 into Azure:main Jan 26, 2025
22 checks passed
Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
* removing extra hyphen in some command examples

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

* Adding short hand annotations for CLI args

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

* Changing default string for resources to be --name

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

---------

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants