Durabletask shorthand fixes and readme fixes#8414
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @RyanLettieri, |
|
Hi @RyanLettieri, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: durabletask
Notes
|
cgillum
left a comment
There was a problem hiding this comment.
There's another inconsistency that I noticed, which is we treat "taskhub" the command as one word, but the "task-hub-name" parameter treats it as two works. To avoid confusion, I suggest we change all usages of --task-hub-name to --taskhub-name or, perhaps even better, --taskhub.
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_create.py
Outdated
Show resolved
Hide resolved
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_show.py
Outdated
Show resolved
Hide resolved
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_create.py
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
368b2a6 to
899c8f3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
* removing extra hyphen in some command examples Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding short hand annotations for CLI args Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Changing default string for resources to be --name Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> --------- Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Associated aaz PR: Azure/aaz#672