Skip to content

2024-09-01-preview update#8335

Merged
necusjz merged 6 commits intoAzure:mainfrom
jamesfan1:feature-nginx-2024-09-01-preview
Jan 23, 2025
Merged

2024-09-01-preview update#8335
necusjz merged 6 commits intoAzure:mainfrom
jamesfan1:feature-nginx-2024-09-01-preview

Conversation

@jamesfan1
Copy link
Member

@jamesfan1 jamesfan1 commented Nov 27, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 27, 2024

❌Azure CLI Extensions Breaking Change Test
❌nginx
rule cmd_name rule_message suggest_message
1007 - ParaRemove nginx deployment configuration create cmd nginx deployment configuration create removed parameter location please add back parameter location for cmd nginx deployment configuration create
1007 - ParaRemove nginx deployment configuration update cmd nginx deployment configuration update removed parameter location please add back parameter location for cmd nginx deployment configuration update
1007 - ParaRemove nginx deployment update cmd nginx deployment update removed parameter location please add back parameter location for cmd nginx deployment update
⚠️ 1011 - SubgroupAdd nginx deployment api-key sub group nginx deployment api-key added

@azure-client-tools-bot-prd
Copy link

Hi @jamesfan1,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 27, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

@necusjz
Copy link
Member

necusjz commented Nov 27, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Nov 28, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Release History
===============

2.0.0b6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2.0.0b7 (consistent with setup.py)

@necusjz
Copy link
Member

necusjz commented Nov 28, 2024

❌Azure CLI Extensions Breaking Change Test

❌nginx

rule
cmd_name
rule_message
suggest_message

1007 - ParaRemove
nginx deployment configuration create
cmd nginx deployment configuration create removed parameter location
please add back parameter location for cmd nginx deployment configuration create

1007 - ParaRemove
nginx deployment configuration update
cmd nginx deployment configuration update removed parameter location
please add back parameter location for cmd nginx deployment configuration update

1007 - ParaRemove
nginx deployment update
cmd nginx deployment update removed parameter location
please add back parameter location for cmd nginx deployment update

⚠️ 1011 - SubgroupAdd
nginx deployment api-key
sub group nginx deployment api-key added

are they as expected?

@jamesfan1
Copy link
Member Author

jamesfan1 commented Dec 2, 2024

@necusjz
These changes are expected

@necusjz
Copy link
Member

necusjz commented Dec 3, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz closed this Dec 4, 2024
@necusjz necusjz reopened this Dec 4, 2024
@github-actions
Copy link

github-actions bot commented Dec 4, 2024

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

@jamesfan1
Copy link
Member Author

@necusjz Happy new year! Since code freeze is lifted, could you please help approve and merge this?

@necusjz
Copy link
Member

necusjz commented Jan 14, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@SpencerOfwiti
Copy link
Member

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8335 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 14, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jamesfan1
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8335 in repo Azure/azure-cli-extensions

@necusjz
Copy link
Member

necusjz commented Jan 20, 2025

@jamesfan1 please fix the ci firstly, https://dev.azure.com/azclitools/public/_build/results?buildId=215760&view=logs&j=85692d73-7fd1-54cf-e8a2-b651dc664eb4&t=5d21126a-3fd1-538a-4d62-56dc95b84a7a&l=489, seems you need to record the test cases regarding the latest dev branch of azure-cli

@jamesfan1
Copy link
Member Author

fixed the test! sorry i had some issue with my local machine before. @necusjz

@necusjz
Copy link
Member

necusjz commented Jan 21, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@SpencerOfwiti
Copy link
Member

@necusjz Can we get some eyes on this?

@necusjz
Copy link
Member

necusjz commented Jan 23, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit 40c5b3f into Azure:main Jan 23, 2025
22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ nginx-2.0.0b7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=113215772&view=results

Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
* 2024-09-01-preview update

* fix linter

* updated history

* synced test with latest dev

* use newest az version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants