Skip to content

[CosmosDB] API Version 2024-12-01-preview#8323

Merged
evelyn-ys merged 18 commits intoAzure:mainfrom
pjohari-ms:cosmosdb-20241201preview
Jan 24, 2025
Merged

[CosmosDB] API Version 2024-12-01-preview#8323
evelyn-ys merged 18 commits intoAzure:mainfrom
pjohari-ms:cosmosdb-20241201preview

Conversation

@pjohari-ms
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 26, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️cosmosdb-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd cosmosdb sql container throughput sub group cosmosdb sql container throughput added

@azure-client-tools-bot-prd
Copy link

Hi @pjohari-ms,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @pjohari-ms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 26, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

Hi @pjohari-ms

Release Suggestions

Module: cosmosdb-preview

  • Please log updates into to src/cosmosdb-preview/HISTORY.rst
  • Update VERSION to 1.1.0b2 in src/cosmosdb-preview/setup.py

Notes

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pjohari-ms
Copy link
Member Author

@evelyn-ys Does this PR also require anything for merge? Seems like all gates are passing.

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

@pjohari-ms Sorry for late response. The PR's CI seems not pass yet. BTW, we can't merge extension PR until 2025-01-06 due to CCOA

Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to release a new version of your extension, don't forget to update the version and history notes

@pjohari-ms
Copy link
Member Author

@evelyn-ys Can you re-run the pipelines? The build is unavailable.
Do I need to rebase this one as well and record tests again?

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

evelyn-ys commented Jan 17, 2025

Do I need to rebase this one as well and record tests again?

Probably yes. I've re-triggered the CI, pls check the results and decide whether to rebase and re-record

@pjohari-ms
Copy link
Member Author

@evelyn-ys Updated with all recordings. Please restart the gates and merge if working. :)

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys evelyn-ys merged commit d098679 into Azure:main Jan 24, 2025
21 of 22 checks passed
@evelyn-ys
Copy link
Member

@pjohari-ms This PR won't trigger extension auto release since version not updated. If you want to release a new version pls raise another PR

Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
* Adding custom SDK from azure-rest-api-specs PR

* Recordings

* Changes to add "sql container throughput" commands

* Added throughput type to sql container throughput migrate

* Added throughput bucket param

* Changes to add "sql container throughput" commands

* Added throughput type to sql container throughput migrate

* Added throughput bucket param

* Removed unused imports

* Remaining test recordings

* Fixed linters

* Fixed examples

* Flake8 changes

* Updated to --throughput-buckets and rerecorded test

* Added final recording

---------

Co-authored-by: Achint-Agrawal <45819170+Achint-Agrawal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot CosmosDB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants