-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Container app] az containerapp env java-component: Support new configuration parameters on java component #8320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
30f26d7
214a192
7e58d05
df1c146
75a20f1
ebf42e7
5000140
71f2a93
262af2f
de41887
77637d8
a57cf7c
283ad3b
4a7887d
d459bd5
8a8ea15
9283205
a87bc57
ea03f2a
8b4f3b8
eb76825
b0d3f2e
5de8280
34fef84
a0a4f5d
d5006c4
15b3679
9367af3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1258,7 +1258,7 @@ | |
| az containerapp env java-component spring-cloud-config create -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| """ | ||
|
|
||
| helps['containerapp env java-component spring-cloud-config delete'] = """ | ||
|
|
@@ -1292,13 +1292,13 @@ | |
| az containerapp env java-component spring-cloud-config update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration | ||
| --remove-all-configurations | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we'd better add some examples about how to use
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure, examples added |
||
| - name: Update a Spring Cloud Config with custom configurations. | ||
| text: | | ||
| az containerapp env java-component spring-cloud-config update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| """ | ||
|
|
||
| helps['containerapp env java-component config-server-for-spring'] = """ | ||
|
|
@@ -1315,7 +1315,7 @@ | |
| az containerapp env java-component config-server-for-spring create -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Create a Config Server for Spring with multiple replicas. | ||
| text: | | ||
| az containerapp env java-component config-server-for-spring create -g MyResourceGroup \\ | ||
|
|
@@ -1350,18 +1350,30 @@ | |
| type: command | ||
| short-summary: Command to update the Config Server for Spring. | ||
| examples: | ||
| - name: Delete all configurations of the Config Server for Spring. | ||
| - name: Update a Config Server for Spring with custom configurations. | ||
| text: | | ||
| az containerapp env java-component config-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration | ||
| - name: Update a Config Server for Spring with custom configurations. | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Replace all configurations of the Config Server for Spring. | ||
| text: | | ||
| az containerapp env java-component config-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --replace-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Delete configurations of the Config Server for Spring. | ||
| text: | | ||
| az containerapp env java-component config-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --remove-configurations PropertyName1 PropertyName2 | ||
| - name: Delete all configurations of the Config Server for Spring. | ||
| text: | | ||
| az containerapp env java-component config-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --remove-all-configurations | ||
|
Comment on lines
+1371
to
+1376
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this is dup with line 1355-1358?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dup removed |
||
| """ | ||
|
|
||
| helps['containerapp env java-component spring-cloud-eureka'] = """ | ||
|
|
@@ -1384,7 +1396,7 @@ | |
| az containerapp env java-component spring-cloud-eureka create -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| """ | ||
|
|
||
| helps['containerapp env java-component spring-cloud-eureka delete'] = """ | ||
|
|
@@ -1418,13 +1430,13 @@ | |
| az containerapp env java-component spring-cloud-eureka update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration | ||
| --remove-all-configurations | ||
| - name: Update a Spring Cloud Eureka with custom configurations. | ||
| text: | | ||
| az containerapp env java-component spring-cloud-eureka update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| """ | ||
|
|
||
| helps['containerapp env java-component eureka-server-for-spring'] = """ | ||
|
|
@@ -1446,7 +1458,7 @@ | |
| az containerapp env java-component eureka-server-for-spring create -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| """ | ||
|
|
||
| helps['containerapp env java-component eureka-server-for-spring delete'] = """ | ||
|
|
@@ -1475,18 +1487,30 @@ | |
| type: command | ||
| short-summary: Command to update the Eureka Server for Spring. | ||
| examples: | ||
| - name: Delete all configurations of the Eureka Server for Spring. | ||
| - name: Update an Eureka Server for Spring with custom configurations. | ||
| text: | | ||
| az containerapp env java-component eureka-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration | ||
| - name: Update an Eureka Server for Spring with custom configurations. | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Replace all configurations of the Eureka Server for Spring. | ||
| text: | | ||
| az containerapp env java-component eureka-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --replace-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Delete configurations of the Eureka Server for Spring. | ||
| text: | | ||
| az containerapp env java-component eureka-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --remove-configurations PropertyName1 PropertyName2 | ||
| - name: Delete all configurations of the Eureka Server for Spring. | ||
| text: | | ||
| az containerapp env java-component eureka-server-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --remove-all-configurations | ||
|
Comment on lines
+1508
to
+1513
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dup with line 1498-1501?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dup removed |
||
| """ | ||
|
|
||
| helps['containerapp env java-component admin-for-spring'] = """ | ||
|
|
@@ -1508,7 +1532,7 @@ | |
| az containerapp env java-component admin-for-spring create -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Create an Admin for Spring with multiple replicas. | ||
| text: | | ||
| az containerapp env java-component admin-for-spring create -g MyResourceGroup \\ | ||
|
|
@@ -1543,18 +1567,30 @@ | |
| type: command | ||
| short-summary: Command to update the Admin for Spring. | ||
| examples: | ||
| - name: Delete all configurations of the Admin for Spring. | ||
| - name: Update an Admin for Spring with custom configurations. | ||
| text: | | ||
| az containerapp env java-component admin-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration | ||
| - name: Update an Admin for Spring with custom configurations. | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Replace all configurations of the Admin for Spring. | ||
| text: | | ||
| az containerapp env java-component admin-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --replace-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Delete configurations of the Admin for Spring. | ||
| text: | | ||
| az containerapp env java-component admin-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --remove-configurations PropertyName1 PropertyName2 | ||
| - name: Delete all configurations of the Admin for Spring. | ||
| text: | | ||
| az containerapp env java-component admin-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --remove-all-configurations | ||
| """ | ||
|
|
||
| helps['containerapp env java-component nacos'] = """ | ||
|
|
@@ -1576,7 +1612,7 @@ | |
| az containerapp env java-component nacos create -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| """ | ||
|
|
||
| helps['containerapp env java-component nacos delete'] = """ | ||
|
|
@@ -1605,18 +1641,30 @@ | |
| type: command | ||
| short-summary: Command to update the Nacos. | ||
| examples: | ||
| - name: Delete all configurations of the Nacos. | ||
| - name: Update an Nacos with custom configurations. | ||
| text: | | ||
| az containerapp env java-component nacos update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration | ||
| - name: Update an Nacos with custom configurations. | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Replace all configurations of the nacos. | ||
| text: | | ||
| az containerapp env java-component nacos update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --replace-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Delete configurations of the nacos. | ||
| text: | | ||
| az containerapp env java-component nacos update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --remove-configurations PropertyName1 PropertyName2 | ||
| - name: Delete all configurations of the nacos. | ||
| text: | | ||
| az containerapp env java-component nacos update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --remove-all-configurations | ||
|
Comment on lines
+1662
to
+1667
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dup?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dup removed |
||
| """ | ||
|
|
||
| helps['containerapp env java-component gateway-for-spring'] = """ | ||
|
|
@@ -1640,7 +1688,7 @@ | |
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --route-yaml MyRouteYamlFilePath \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Create a Gateway for Spring with multiple replicas. | ||
| text: | | ||
| az containerapp env java-component gateway-for-spring create -g MyResourceGroup \\ | ||
|
|
@@ -1682,18 +1730,30 @@ | |
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --route-yaml MyRouteYamlFilePath | ||
| - name: Delete all configurations of the Gateway for Spring. | ||
| - name: Update a Gateway for Spring with custom configurations. | ||
| text: | | ||
| az containerapp env java-component gateway-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration | ||
| - name: Update a Gateway for Spring with custom configurations. | ||
| --set-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Replace all configurations of the Gateway for Spring. | ||
| text: | | ||
| az containerapp env java-component gateway-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --replace-configurations PropertyName1=Value1 PropertyName2=Value2 | ||
| - name: Delete configurations of the Gateway for Spring. | ||
| text: | | ||
| az containerapp env java-component gateway-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --remove-configurations PropertyName1 PropertyName2 | ||
| - name: Delete all configurations of the Gateway for Spring. | ||
| text: | | ||
| az containerapp env java-component gateway-for-spring update -g MyResourceGroup \\ | ||
| -n MyJavaComponentName \\ | ||
| --environment MyEnvironment \\ | ||
| --configuration PropertyName1=Value1 PropertyName2=Value2 | ||
| --remove-all-configurations | ||
| """ | ||
|
|
||
| # Container Apps Telemetry Commands | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -371,7 +371,11 @@ def load_arguments(self, _): | |
| c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None) | ||
| c.argument('service_bindings', nargs='*', options_list=['--bind'], help="Space separated list of services, bindings or other Java components to be connected to this Java Component. e.g. SVC_NAME1[:BIND_NAME1] SVC_NAME2[:BIND_NAME2]...") | ||
| c.argument('unbind_service_bindings', nargs='*', options_list=['--unbind'], help="Space separated list of services, bindings or Java components to be removed from this Java Component. e.g. BIND_NAME1...") | ||
| c.argument('configuration', nargs="*", help="Java component configuration. Configuration must be in format `<propertyName>=<value>` `<propertyName>=<value>`...") | ||
| c.argument('configuration', nargs="*", help="Java component configuration. Configuration must be in format `<propertyName>=<value>` `<propertyName>=<value>`...", deprecate_info=c.deprecate(target="--configuration", redirect='--[set|replace|remove|remove-all]-configurations', hide=True)) | ||
| c.argument('set_configurations', nargs="*", options_list=['--set-configurations', '--set-configs'], help="Add or update Java component configuration(s). Other existing configurations are not modified. Configuration must be in format `<propertyName>=<value>` `<propertyName>=<value>`...") | ||
| c.argument('replace_configurations', nargs="*", options_list=['--replace-configurations', '--replace-configs'], help="Replace Java component configuration(s), Other existing configurations are removed. Configuration must be in format `<propertyName>=<value>` `<propertyName>=<value>`...") | ||
| c.argument('remove_configurations', nargs="*", options_list=['--remove-configurations', '--remove-configs'], help="Remove Java component configuration(s). Specify configuration names separated by space, in format `<propertyName>` `<propertyName>`...") | ||
| c.argument('remove_all_configurations', arg_type=get_three_state_flag(), options_list=['--remove-all-configurations', '--remove-all-configs'], help="Remove all Java component configuration(s).") | ||
|
Comment on lines
+377
to
+378
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Because these two parameters are similar, can they be merged into one parameter? For example, when
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, got it~ |
||
| c.argument('min_replicas', type=int, help="Minimum number of replicas to run for the Java component.") | ||
| c.argument('max_replicas', type=int, help="Maximum number of replicas to run for the Java component.") | ||
| c.argument('route_yaml', options_list=['--route-yaml', '--yaml'], help="Path to a .yaml file with the configuration of a Spring Cloud Gateway route. For an example, see https://aka.ms/gateway-for-spring-routes-yaml") | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some examples for this parameter
--replace-configurationsto describe how to use it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, examples added