[cosmosdb-preview] Add support for new api version 2024-02-15-preview #7271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @carjackson-msft, |
Collaborator
|
cosmosdb-preview |
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
microsoft-github-policy-service
bot
added
CosmosDB
Auto-Assign
(cherry picked from commit a28144517ad4022098561e83d8607c93933dd36c)
(cherry picked from commit 3d721cb) (cherry picked from commit f4e6f01f99eb1299e8c536423f074e9832b71e16)
…toscale cli changes for PRPP
Online container copy
… add remaining asserts, rerecordings
…th_ttl_disabled Introduce disable_ttl parameter
ghost
marked this pull request as ready for review
Collaborator
|
Please fix CI issues |
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7271 in repo Azure/azure-cli-extensions |
Author
|
Hi @yonzhan, can you please help in triggering CLI checks to run? Seems I do not have sufficient privileges. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
evelyn-ys
reviewed
Mar 8, 2024
Member
|
Please fix CI failure on style check |
Author
Hi @evelyn-ys, is the style check required? According to the pipeline "This task does not block the PR merge." I also ran the azdev style check locally and don't see any errors:
I took a look at the errors in the pipeline, they seem to be for existing tests/changes. Given this is not a required check, can we disregard? |
Member
|
Pls upgrade your local |
Author
|
@evelyn-ys style has been fixed. |
evelyn-ys
approved these changes
Mar 13, 2024
evelyn-ys
reviewed
Mar 13, 2024
evelyn-ys
requested changes
Mar 13, 2024
Member
evelyn-ys
left a comment
evelyn-ys
left a comment
There was a problem hiding this comment.
Please update the version in HISTORY.rst to align with the version in setup.py
Author
|
Hi @evelyn-ys, this has been fixed. Can we please merge this? |
evelyn-ys
approved these changes
Mar 20, 2024
Collaborator
|
[Release] Update index.json for extension [ cosmosdb-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=140834&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.