Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/containerapp/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ upcoming
* 'az containerapp env create': support --mi-system-assigned and --mi-user-assigned for environment create commands
* 'az containerapp env identity': support for container app environment assign/remove/show commands
* 'az containerapp env storage set': Support create or update managed environment storage with NFS Azure File.
* 'az containerapp up': Update the Docker error string used to identify unauthorized push.

0.3.46
++++++
Expand Down
2 changes: 1 addition & 1 deletion src/containerapp/azext_containerapp/_up_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ def _docker_push_to_container_registry(self, image_name, forced_acr_login=False)
_, stderr = process.communicate()
if process.returncode != 0:
docker_push_error = stderr.decode('utf-8')
if not forced_acr_login and ".azurecr.io/" in image_name and "unauthorized: authentication required" in docker_push_error:
if not forced_acr_login and ".azurecr.io/" in image_name and "unauthorized" in docker_push_error:
# Couldn't push to ACR because the user isn't authenticated. Let's try to login to ACR and retrigger the docker push
logger.warning(f"The current user isn't authenticated to the {self.acr.name} ACR instance. Triggering an ACR login and retrying to push the image...")
# Logic to login to ACR
Expand Down
695,545 changes: 349,892 additions & 345,653 deletions ...ntainerapp/tests/latest/recordings/test_containerapp_up_artifact_with_buildpack_java.yaml

Large diffs are not rendered by default.

Loading