Skip to content

Conversation

@xuexu6666
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool delete-machines
delete machines API was added to 2023-10-02-preview

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 2, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd aks nodepool delete-machines cmd aks nodepool delete-machines added

@azure-client-tools-bot-prd
Copy link

Hi @xuexu6666,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @xuexu6666,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 2, 2024

AKS

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yanzhudd
Copy link
Contributor

yanzhudd commented Feb 7, 2024

please resolve code conflicts

@xuexu6666
Copy link
Contributor Author

@zhoxing-ms

Resolved your comments. Mind a final look? Thanks.

@yanzhudd yanzhudd merged commit e71b504 into Azure:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants