Skip to content

Conversation

@njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jan 30, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 30, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter system_assigned
⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter user_assigned
⚠️ 1011 - SubgroupAdd containerapp env identity sub group containerapp env identity added

@azure-client-tools-bot-prd
Copy link

Hi @njuCZ,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @njuCZ,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 30, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@njuCZ njuCZ changed the title Support Env Managed Identity [Containerapp] 'az containerapp env create': Support --mi-system-assigned and --mi-user-assigned, support 'az containerapp env identity assign/remove/show' Jan 31, 2024
@njuCZ njuCZ force-pushed the user/njucz/support_env_MI branch from e7e2ca5 to 1fb75fc Compare February 1, 2024 05:32
@Greedygre
Copy link
Contributor

Hi @zhoxing-ms @wangzelin007

The az containerapp service is deprecated from 2.56.1, after azure-cli version 2.57.0 release in dev , the linter failed with following error, can you help to handle it? Thanks.


    Parameter: containerapp service postgres create, `service_name` - Missing help
    Parameter: containerapp service postgres delete, `_subscription` - Missing help
    Parameter: containerapp service postgres delete, `cmd` - Missing help
    Parameter: containerapp service postgres delete, `no_wait` - Missing help
    Parameter: containerapp service postgres delete, `resource_group_name` - Missing help
    Parameter: containerapp service postgres delete, `service_name` - Missing help
    Parameter: containerapp service postgres delete, `yes` - Missing help
    Parameter: containerapp service qdrant create, `_subscription` - Missing help
    Parameter: containerapp service qdrant create, `cmd` - Missing help
    Parameter: containerapp service qdrant create, `disable_warnings` - Missing help
    Parameter: containerapp service qdrant create, `environment_name` - Missing help
    Parameter: containerapp service qdrant create, `no_wait` - Missing help
    Parameter: containerapp service qdrant create, `resource_group_name` - Missing help
    Parameter: containerapp service qdrant create, `service_name` - Missing help
    Parameter: containerapp service qdrant delete, `_subscription` - Missing help
    Parameter: containerapp service qdrant delete, `cmd` - Missing help
    Parameter: containerapp service qdrant delete, `no_wait` - Missing help
    Parameter: containerapp service qdrant delete, `resource_group_name` - Missing help
    Parameter: containerapp service qdrant delete, `service_name` - Missing help
    Parameter: containerapp service qdrant delete, `yes` - Missing help
    Parameter: containerapp service redis create, `_subscription` - Missing help
    Parameter: containerapp service redis create, `cmd` - Missing help
    Parameter: containerapp service redis create, `disable_warnings` - Missing help
    Parameter: containerapp service redis create, `environment_name` - Missing help
    Parameter: containerapp service redis create, `no_wait` - Missing help
    Parameter: containerapp service redis create, `resource_group_name` - Missing help
    Parameter: containerapp service redis create, `service_name` - Missing help
    Parameter: containerapp service redis delete, `_subscription` - Missing help
    Parameter: containerapp service redis delete, `cmd` - Missing help
    Parameter: containerapp service redis delete, `no_wait` - Missing help
    Parameter: containerapp service redis delete, `resource_group_name` - Missing help
    Parameter: containerapp service redis delete, `service_name` - Missing help
    Parameter: containerapp service redis delete, `yes` - Missing help

@njuCZ njuCZ force-pushed the user/njucz/support_env_MI branch from 3379af4 to 684d6e8 Compare February 1, 2024 08:52
@yanzhudd yanzhudd merged commit f0715eb into Azure:main Feb 2, 2024
@njuCZ njuCZ deleted the user/njucz/support_env_MI branch February 2, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants