[Spring] Add new params for ACS settings #7187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| spring application-configuration-service create | cmd spring application-configuration-service create added parameter refresh_interval |
||
| spring application-configuration-service update | cmd spring application-configuration-service update added parameter refresh_interval |
|
Hi @moarychan, |
microsoft-github-policy-service
bot
requested review from
yanzhudd and
zhoxing-ms
Collaborator
|
Spring |
microsoft-github-policy-service
bot
requested review from
FumingZhang and
yonzhan
moarychan
force-pushed
the
moary/enable-acs-config-pull-interval
branch
from
25d94ec to
97217a7
Compare
moarychan
changed the title
Member
Author
|
Hi, @yuwzho please help to review this PR, thanks! |
yuwzho
reviewed
Jan 22, 2024
src/spring/azext_spring/tests/latest/test_asa_application_configuration_service.py
Outdated
Show resolved
Hide resolved
Member
Author
|
Hi @zhoxing-ms @yanzhudd @FumingZhang, could you help to merge this PR? Many thanks! |
Member
Author
|
Hi @yonzhan, could you help to merge this PR? Thanks！ |
yanzhudd
approved these changes
Feb 5, 2024
Collaborator
|
[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=127638&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new params for ACS.
Related command
--refresh-intervalinspring application-configuration-service create--refresh-intervalinspring application-configuration-service updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.