-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Whitelist Version Check for Non-Stable Release Trains for connectedk8s #7139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhoxing-ms
merged 3 commits into
Azure:main
from
kitnhl:kitnguyen/connectedk8s-whitelist-dev-train
Jan 12, 2024
Merged
Whitelist Version Check for Non-Stable Release Trains for connectedk8s #7139
zhoxing-ms
merged 3 commits into
Azure:main
from
kitnhl:kitnguyen/connectedk8s-whitelist-dev-train
Jan 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @kitnhl, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
NarayanThiru
suggested changes
Jan 2, 2024
NarayanThiru
approved these changes
Jan 2, 2024
zhoxing-ms
reviewed
Jan 11, 2024
zhoxing-ms
approved these changes
Jan 12, 2024
Collaborator
|
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=121306&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip checking operation version support for non-stable release trains.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedk8s upgrade -g <rg_name> -n <cluster_name>
(should work for any version for dev/private/other-non-stable release trains, but only for v>1.1.14 for stable release train, the same applies for az connectedk8s update/enable-features/disable-features)
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.