Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 26, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 26, 2023

AKS

@mukhoakash
Copy link
Contributor

LGTM

@FumingZhang
Copy link
Member Author

FumingZhang commented Dec 29, 2023

Queued live test to validate the change.

  • test_aks_create_with_azurecontainerstorage
  • test_aks_create_with_azurecontainerstorage_with_nodepool_name

Test passed!

@yanzhudd yanzhudd merged commit 7e6e5c0 into Azure:main Dec 29, 2023
@FumingZhang FumingZhang deleted the fuming/aks-style-cs-1226 branch January 4, 2024 06:07
ddouglas-msft pushed a commit to ddouglas-msft/azure-cli-extensions that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants