Skip to content

[devcenter] Update project environment type parameters to be required #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 4 commits into from
Dec 22, 2023
Merged

[devcenter] Update project environment type parameters to be required #7100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3012045
Update project env type parameters
am-lim Dec 19, 2023
8f9ea26
Merge pull request #14 from am-lim/amlim/updateProjectEnvType
am-lim Dec 19, 2023
2657a39
Fix environment def example and update style
am-lim Dec 19, 2023
2e955c4
Merge pull request #15 from am-lim/amlim/fixEnvDefExample
am-lim Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/devcenter/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
5.0.0
++++++
* Require roles and identity type parameters in "az decenter admin project-environment-type create"

4.0.1
++++++
* Update due to bug in API swagger causing missing API version
Expand Down
2 changes: 1 addition & 1 deletion src/devcenter/azext_devcenter/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@
--project-name "DevProject"
- name: List using endpoint
text: |-
az devcenter dev environment-definition list --dev-center-name "ContosoDevCenter" \
az devcenter dev environment-definition list --endpoint "https://8a40af38-3b4c-4672-a6a4-5e964b1870ed-contosodevcenter.centralus.devcenter.azure.com/" \
--project-name "DevProject"
- name: List by catalog using dev center
text: |-
Expand Down
1 change: 1 addition & 0 deletions src/devcenter/azext_devcenter/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# pylint: disable=line-too-long
# pylint: disable=unused-import
# pylint: disable=too-many-statements
# pylint: disable=too-many-lines

from knack.arguments import CLIArgumentType
from azure.cli.core.commands.parameters import (
Expand Down
4 changes: 0 additions & 4 deletions src/devcenter/azext_devcenter/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,8 @@
# Changes may cause incorrect behavior and will be lost if the code is
# regenerated.
# --------------------------------------------------------------------------


# pylint: disable=protected-access

# pylint: disable=no-self-use


import argparse
from collections import defaultdict
Expand Down
3 changes: 3 additions & 0 deletions src/devcenter/azext_devcenter/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
# pylint: disable=protected-access
# pylint: disable=too-many-lines

from datetime import datetime
import json
Expand Down Expand Up @@ -459,6 +460,8 @@ def _build_arguments_schema(cls, *args, **kwargs):
args_schema = super()._build_arguments_schema(*args, **kwargs)
args_schema.deployment_target_id._required = True
args_schema.status._required = True
args_schema.roles._required = True
args_schema.identity_type._required = True
return args_schema

def _cli_arguments_loader(self):
Expand Down
Loading