-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Stackhcivm 0.1.8 #7017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stackhcivm 0.1.8 #7017
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @wyatt-troia-msft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
@yonzhan is there an ETA for the review? |
|
Please fix the conflicting files |
13adc2f to
a49a9af
Compare
@yonzhan Done. I had neglected to update my fork based on the upstream (this repo). |
|
@yonzhan I do not understand the CI failures. Can you please advise on how to clear them? |
|
There are some invalid examples in your code https://dev.azure.com/azclitools/public/_build/results?buildId=111708&view=logs&j=ccdac6d3-465a-5ada-8819-d5b4a6b3a631&t=0babf5d5-1acc-5198-6505-1f9f83b6d5c0&l=134 |
I don't understand this error. I've compared the metadata for the new block I'm adding and the block for the last version of stack-hci-vm and they seem to be nearly identical. The error seems to be saying that the metadata for version 1.8 should say that its version is 1.5. Why would that be? |
Can you verify the whl package in the download link is version 1.8? |
@kairu-ms from the pipeline error logs, I see that the metadata shows version as 0.1.5 whereas the changes in the PR has it as 0.1.8 I have also verified from the file that the metadata version is indeed 0.1.8 Is there a different place from where the pipeline is picking up the version? |
|
@wyatt-troia-msft @Arkanayan do we need this kind of change before we build the whl file? |
|
We can close this as these changes are merged in #7052 |



This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.