Skip to content

[containerapp] Give a better error message when customer uses --artif… #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 3 commits into from
Nov 11, 2023
Merged

[containerapp] Give a better error message when customer uses --artif… #6983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2724e2a
[containerapp] Give a better error message when customer uses --artif…
daniv-msft Nov 11, 2023
6d15213
Clarify the error message
daniv-msft Nov 11, 2023
2c7c8ce
Minor update
daniv-msft Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/containerapp/azext_containerapp/_up_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,10 @@ def build_container_from_source_with_acr_task(self, image_name, source):
from azure.cli.command_modules.acr._client_factory import cf_acr_tasks, cf_acr_runs
from azure.cli.core.profiles import ResourceType

# Validate that the source provided is a directory, and not a file.
Copy link
Contributor

@Greedygre Greedygre Nov 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous code, the source value is infer from artifact, the customer not input --source, but can see this error when docker is not running .

if os.path.isfile(source):
raise ValidationError(f"Impossible to build the artifact file {source} with ACR Task. Please make sure that you use --source and target a directory, or if you want to build your artifact locally, please make sure Docker is running on your machine.")

task_name = "cli_build_containerapp"
registry_name = (self.registry_server[: self.registry_server.rindex(ACR_IMAGE_SUFFIX)]).lower()
if not self.target_port:
Expand Down
Loading