[containerapp] az containerapp add-on create: Support add-on commands; deprecation of service commands by scrappywyrm · Pull Request #6960 · Azure/azure-cli-extensions

scrappywyrm · 2023-11-07T23:18:15Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2023-11-07T23:18:18Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1011 - SubgroupAdd containerapp add-on sub group containerapp add-on added

azure-client-tools-bot-prd · 2023-11-07T23:18:21Z

Hi @bgashirabake,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2023-11-07T23:18:24Z

Hi @bgashirabake,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan · 2023-11-07T23:18:28Z

containerapp

microsoft-github-policy-service · 2023-11-07T23:18:45Z

Thank you for your contribution bgashirabake! We will review the pull request and get back to you soon.

Greedygre · 2023-11-08T02:55:34Z

Please not mark test to live_only, for error log workspace api-version does not correct, please pull the newest code in azure-cli, the setup again with command:
azdev setup --cli path-for\azure-cli --repo path-for\azure-cli-extensions
:

except CannotOverwriteExistingCassetteException as ex:
>           raise AssertionError(ex)
E           AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_service_binding_e2e.yaml') in your current record mode ('once').
E           No match for the request (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2022-10-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2022-10-01%3E)) was found.
E           Found 1 similar requests with 1 different matcher(s) :
E           
E           1 - (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2021-12-01-preview>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2021-12-01-preview%3E).)
E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E           Matchers failed :
E           _custom_request_query_matcher - assertion failure :
E           None

src/containerapp/HISTORY.rst

src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py

scrappywyrm · 2023-11-08T08:30:15Z

Please not mark test to live_only, for error log workspace api-version does not correct, please pull the newest code in azure-cli, the setup again with command: azdev setup --cli path-for\azure-cli --repo path-for\azure-cli-extensions :

except CannotOverwriteExistingCassetteException as ex:
>           raise AssertionError(ex)
E           AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_service_binding_e2e.yaml') in your current record mode ('once').
E           No match for the request (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2022-10-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2022-10-01%3E)) was found.
E           Found 1 similar requests with 1 different matcher(s) :
E           
E           1 - (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2021-12-01-preview>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/clitest.rg000001/providers/Microsoft.OperationalInsights/workspaces/containerapp-env000004?api-version=2021-12-01-preview%3E).)
E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E           Matchers failed :
E           _custom_request_query_matcher - assertion failure :
E           None

yea the cli-repo re-setup was a blindspot. synced and all's back to recording state!

scrappywyrm · 2023-11-08T09:06:14Z

ready for review cc: @tawalke @Greedygre @yanzhudd . thank you all!!

Greedygre · 2023-11-08T09:17:16Z

src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py

please check the provisiongState for result. Same as blow.

the provisioningState of all addons is checked in the for loop

Greedygre · 2023-11-08T10:51:38Z

@Juliehzl Could you help to review this PR?

Juliehzl · 2023-11-09T05:01:27Z

src/containerapp/azext_containerapp/commands.py

        g.custom_command('list', 'list_all_services')

-    with self.command_group('containerapp service redis') as g:
+    with self.command_group('containerapp addon', is_preview=True) as g:


what using containerapp add-on?

sorry, i don't get your question...help explain more?

but by the section that you commented on, the addon command group is the equivalent of the service one that's right above it

The question is should we use az containerapp add-on instead of using az containerapp addon ? @bgashirabake

oh got it got it. in discussions with @SimonJakesch, addon was what was decided on, but i just checked the docs and add-on is what's being referenced. i can push the change for add-on in the morning but if release time is before then, i say we go with addon. the change is straight-forward so should be seamless if made in time

Greedygre · 2023-11-09T16:13:29Z

Hi @zhoxing-ms

Could you please help to review this PR? Thanks.

scrappywyrm · 2023-11-09T21:23:59Z

Hi @zhoxing-ms Xing Zhou FTE

Could you please help to review this PR? Thanks.

+

azure-client-tools-bot-prd bot added this to the November 2023 (2023-12-05) milestone Nov 7, 2023

microsoft-github-policy-service bot requested review from wangzelin007, yanzhudd, yonzhan and zhoxing-ms November 7, 2023 23:18

microsoft-github-policy-service bot requested review from Greedygre, JennyLawrance, Juliehzl, chinadragon0515, ebencarek, howang-ms, jijohn14, jsntcy, pagariyaalok, ruslany, sanchitmehta, torosent, vinisoto and vturecek November 7, 2023 23:18

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 7, 2023

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Nov 7, 2023

microsoft-github-policy-service bot assigned zhoxing-ms Nov 7, 2023

microsoft-github-policy-service bot added the ContainerApp label Nov 7, 2023

Juancpani reviewed Nov 8, 2023

View reviewed changes

src/containerapp/HISTORY.rst Outdated Show resolved Hide resolved

Juancpani approved these changes Nov 8, 2023

View reviewed changes

yanzhudd reviewed Nov 8, 2023

View reviewed changes

src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Outdated Show resolved Hide resolved

yanzhudd reviewed Nov 8, 2023

View reviewed changes

src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py Outdated Show resolved Hide resolved

Greedygre reviewed Nov 8, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

scrappywyrm added 5 commits November 8, 2023 13:04

add

9d479eb

recordings

d7f7919

recordings live

6fbd6b7

re-record

8763836

fix

2f4d7f1

scrappywyrm force-pushed the user/bgashirabake/service-to-addon branch from 85127b1 to 2f4d7f1 Compare November 8, 2023 21:06

fix

90248c2

scrappywyrm requested a review from yanzhudd November 8, 2023 23:38

Juliehzl reviewed Nov 9, 2023

View reviewed changes

add-on

a9dc64a

scrappywyrm changed the title ~~[containerapp] az containerapp addon create: Support deprecation of service command in favor of addon~~ [containerapp] az containerapp add-on create: Support add-on commands; deprecation of service commands Nov 9, 2023

Greedygre approved these changes Nov 9, 2023

View reviewed changes

zhoxing-ms approved these changes Nov 10, 2023

View reviewed changes

zhoxing-ms merged commit fbb8641 into Azure:main Nov 10, 2023

Conversation

scrappywyrm commented Nov 7, 2023

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Nov 7, 2023

Uh oh!

azure-client-tools-bot-prd bot commented Nov 7, 2023

Uh oh!

yonzhan commented Nov 7, 2023

Uh oh!

microsoft-github-policy-service bot commented Nov 7, 2023

Uh oh!

Greedygre commented Nov 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scrappywyrm commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scrappywyrm commented Nov 8, 2023

Uh oh!

Greedygre Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

scrappywyrm Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Greedygre commented Nov 8, 2023

Uh oh!

Juliehzl Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

scrappywyrm Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

scrappywyrm Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Greedygre Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

scrappywyrm Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Greedygre commented Nov 9, 2023

Uh oh!

scrappywyrm commented Nov 9, 2023

+

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

azure-client-tools-bot-prd bot commented Nov 7, 2023 •

edited

Loading

scrappywyrm commented Nov 8, 2023 •

edited

Loading

scrappywyrm Nov 9, 2023 •

edited

Loading

scrappywyrm Nov 9, 2023 •

edited

Loading