Skip to content

[containerapp] Add support for --artifact, bug fixes and tests#6954

Merged
zhoxing-ms merged 11 commits intoAzure:mainfrom
daniv-msft:main
Nov 10, 2023
Merged

[containerapp] Add support for --artifact, bug fixes and tests#6954
zhoxing-ms merged 11 commits intoAzure:mainfrom
daniv-msft:main

Conversation

@daniv-msft
Copy link
Copy Markdown
Contributor

@daniv-msft daniv-msft commented Nov 7, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 7, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp create cmd containerapp create added parameter artifact
⚠️ 1006 - ParaAdd containerapp up cmd containerapp up added parameter artifact
⚠️ 1006 - ParaAdd containerapp update cmd containerapp update added parameter artifact

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @daniv-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @daniv-msft,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 7, 2023

containerapp

Copy link
Copy Markdown
Contributor

@Greedygre Greedygre Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if arcname is None? None == "" return false

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe it could happen today given the logic, but I'm updating the code to also take "None" into account

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 8, 2023

Please fix conflicting files.

@Greedygre
Copy link
Copy Markdown
Contributor

Greedygre commented Nov 9, 2023

Hi @daniv-msft
Please fix the CI.
Please add artifact in params for command containerapp up

  • FAIL - HIGH severity: missing_parameter_help
    Parameter: containerapp up, artifact - Missing help

@Greedygre
Copy link
Copy Markdown
Contributor

Hi @zhoxing-ms

Can you help to review this PR? Thanks.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 9, 2023

Please fix CI issues.

@zhoxing-ms zhoxing-ms merged commit d0d073d into Azure:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants