[containerapp] Add support for --artifact, bug fixes and tests#6954
[containerapp] Add support for --artifact, bug fixes and tests#6954zhoxing-ms merged 11 commits intoAzure:mainfrom daniv-msft:main
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp create | cmd containerapp create added parameter artifact |
||
| containerapp up | cmd containerapp up added parameter artifact |
||
| containerapp update | cmd containerapp update added parameter artifact |
|
Hi @daniv-msft, |
|
Hi @daniv-msft, |
|
containerapp |
There was a problem hiding this comment.
What if arcname is None? None == "" return false
There was a problem hiding this comment.
I don't believe it could happen today given the logic, but I'm updating the code to also take "None" into account
|
Please fix conflicting files. |
|
Hi @daniv-msft
|
|
Hi @zhoxing-ms Can you help to review this PR? Thanks. |
|
Please fix CI issues. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.