[AKS] Approuting cli simplification #6902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosesuneha
requested review from
FumingZhang and
andyliuliming
as code owners
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks approuting | sub group aks approuting added |
||
| aks create | cmd aks create added parameter enable_app_routing |
|
Hi @bosesuneha, |
FumingZhang
reviewed
Oct 26, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
basically lgtm
queued live test to valiate the change
Member
|
Please fix failed CI checks
|
zhoxing-ms
reviewed
Nov 7, 2023
zhoxing-ms
reviewed
Nov 7, 2023
zhoxing-ms
reviewed
Nov 7, 2023
zhoxing-ms
reviewed
Nov 7, 2023
zhoxing-ms
reviewed
Nov 7, 2023
zhoxing-ms
reviewed
Nov 7, 2023
zhoxing-ms
reviewed
Nov 7, 2023
Contributor
|
@bosesuneha Could you please resolve these conflicts |
3 tasks
Member
|
Replaced by #6958, hard to rebase/merge main and fix failed CI check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks approuting enable --enable-kvThis command enables App Routing addon in given cluster. The optional flag enables the keyvault-secrets-provider addon in given cluster.
az aks approuting disableThis command disables App Routing in given cluster.
az aks approuting update --attach-kv <keyvault-id>This command is used to update
keyvault idin App Routing addon. Attach akeyvault idto the cluster to access secrets and certificates.az aks approuting zone add/delete --ids <dns-zone-resource-id> --attach-zonesThis command adds/deletes multiple DNS zone resource IDs in App Routing. It takes comma-separated list of DNS zone resource IDs.
--attach-zonesflag grants DNS zone Contributor permissions on all zone IDs specified in--ids.az aks approuting zone update --ids <dns-zone-resource-id>,<dns-zone-resource-id-2> --attach-zonesThis command replaces the DNS zone resource IDs used in App Routing.
az aks approuting zone listThis command lists the DNS zones in App Routing.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.